schema: add POI JSON schema v2.0.0#530
Open
raphael-ram wants to merge 3 commits into
Open
Conversation
mathieu1fb
reviewed
May 27, 2026
Signed-off-by: Raphael Ramanantsoa <raphael.ramanantsoa@orange.com>
Signed-off-by: Raphael Ramanantsoa <raphael.ramanantsoa@orange.com>
fbd509e to
ea560ab
Compare
mathieu1fb
reviewed
May 28, 2026
mathieu1fb
reviewed
May 28, 2026
mathieu1fb
reviewed
May 28, 2026
mathieu1fb
reviewed
May 28, 2026
mathieu1fb
reviewed
May 28, 2026
mathieu1fb
reviewed
May 28, 2026
mathieu1fb
reviewed
May 28, 2026
mathieu1fb
reviewed
May 28, 2026
Collaborator
|
I didn't comment on all occurrences, but definition of values is sometimes missing, or the definition is present but the unit is most often missing. The schema should be self-explanatory so it is important to find these missing pieces. |
Collaborator
|
Also, it would be better to format the directory as |
- Rename directory poi/ → poim/ to match the actual message name and align with other message directories (cam/, denm/, etc.) - Rename aggregatedstatus → aggregated_status, detailedstatus → detailed_status, roadsegment → road_segment (snake_case convention) - Add enumerated values for goods_type, parking_fee_type, parking_reservation_type, arrangement_type, current_facility_status, occupancy trend, engine_characteristics (from POIM-ParkingAvailability.asn and EfcDataDictionary-v1-3.asn) - Add units for height_restriction, geo_position lat/lon/alt, delta_latitude/longitude/altitude, wgs84_angle value/confidence, occupancy rate/confidence (from ETSI-ITS-CDD.asn) - Add descriptions for all remaining fields: strings (name, address, phone_number, website, pricing_information, etc.), arrays, time_of_day components, level, begin/end_of_period Signed-off-by: Raphael Ramanantsoa <raphael.ramanantsoa@orange.com>
Collaborator
|
Almost perfect with the new changes, thank you. Can you just remove all the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the POIM (Point of Interest Message) JSON Schema v2.0.0 at
schema/poim/poim_schema_2-0-0.json.This schema defines the message format for POIM messages exchanged on the V2X platform (parking availability, road segments, etc.), based on ETSI TS 103 916 v1.1.
Changes
schema/poi/→schema/poim/to match the actual message name conventionschema/poim/poim_schema_2-0-0.json: full JSON Schema for POIM messages (v2.0.0)EngineCharacteristicsuses real enumerated values from ISO 17573-3 v1.3 (EfcDataDictionary) instead of a generic integerGoodsType,ParkingFeeType,ParkingReservationType,ArrangementType,CurrentFacilityStatus,OccupancyTrend) populated from ASN.1 sourcesASN.1 sources used
POIM-PDU-Description.asnPOIM-CommonContainers.asnPOIM-ParkingAvailability.asnGoodsType,ParkingFeeType,ParkingReservationType,ArrangementType,CurrentFacilityStatus,OccupancyTrend,EngineCharacteristics)ETSI-ITS-CDD.asnLatitude,Longitude,Altitude,DeltaLatitude,DeltaLongitude,DeltaAltitude,Wgs84AngleValue,Wgs84AngleConfidence,HeightCharacteristic)EfcDataDictionary-v1-3.asnEngineCharacteristicsReferences
EfcDataDictionary-v1-3.asn
EfcDataDictionary-v1-3.md
ETSI-ITS-CDD.md
POIM-CommonContainers.md
POIM-ParkingAvailability.md
POIM-PDU-Description.md