schema: add MCM JSON schema v2.0.0#511
Conversation
|
I think that the overall structure of the schema if good. Some arrays should point to the objects that they contain, and some extra definitions have to be found for the "null" objects. For instance, ASN.1 definitions of the MCM don't seem to be complete: @nbuffon @ymorin-orange @tigroo31 any ideas? |
Resolved in #512 |
|
Looks all good to me now, thanks @raphael-ram. Let's now wait for a review of @nbuffon, @tigroo31 or @ymorin-orange before merging. |
|
Ok. I've just made another commit to formalize the required fields of way_point because this doesn't respect the initial format of other's required fields. |
ymorin-orange
left a comment
There was a problem hiding this comment.
Question to adress with @nbuffon (for the same question in the CAM): should the message_format be part of the required list?
Signed-off-by: Raphael Ramanantsoa <raphael.ramanantsoa@orange.com>
…tics to $defs Signed-off-by: Raphael Ramanantsoa <raphael.ramanantsoa@orange.com>
…or WayPoint and Trajectory Signed-off-by: Raphael Ramanantsoa <raphael.ramanantsoa@orange.com>
…nematics_characteristics Signed-off-by: Raphael Ramanantsoa <raphael.ramanantsoa@orange.com>
…itude_value to altitude in way_point Signed-off-by: Raphael Ramanantsoa <raphael.ramanantsoa@orange.com>
…ude_position/longitude_position naming Signed-off-by: Raphael Ramanantsoa <raphael.ramanantsoa@orange.com>
…sition to *_value per reviewer comments Signed-off-by: Raphael Ramanantsoa <raphael.ramanantsoa@orange.com>
Signed-off-by: Raphael Ramanantsoa <raphael.ramanantsoa@orange.com>
Signed-off-by: Raphael Ramanantsoa <raphael.ramanantsoa@orange.com>
93389eb to
aa5a497
Compare
nbuffon
left a comment
There was a problem hiding this comment.
Comments from Frédéric review
- Add description to advised_trr_container (TRR = Target Road Resource) - Extend trr_type description with explanation of each type (1/2/3) - Rename t_rr_occupancy_* to trr_occupancy_* (fix tRR→trr naming in ASN.1) - Clarify kinematics_characteristics $comment (intentionally empty, NULL in ASN.1) Signed-off-by: Raphael Ramanantsoa <raphael.ramanantsoa@orange.com>
Signed-off-by: Raphael Ramanantsoa <raphael.ramanantsoa@orange.com>
a576953 to
09a2600
Compare
mathieu1fb
left a comment
There was a problem hiding this comment.
Thanks @raphael-ram for all the work, we can now approve this first version of the MCM JSON schema!
Summary
Add the MCM (Manoeuvre Coordination Message) JSON Schema v2.0.0, based on ETSI TS 103 561 v1.1.
Close #512
Changes
Add
schema/mcm/mcm_schema_2-0-0.jsontrajectoryis an array (SEQUENCE (SIZE(1..10)) OF WayPoint), items reference$ref: #/$defs/way_pointway_pointis a SEQUENCE withway_point_type,longitude,latitude,speed(required),altitude,heading(optional)longitudeandlatitudeinway_pointreference$ref: #/$defs/longitude_valueand$ref: #/$defs/latitude_valuealtitudeinway_pointreferences$ref: #/$defs/altitude_value(integer, ETSI WGS84 bounds)altitudeinreference_positionreferences$ref: #/$defs/altitude(object withaltitude_value+altitude_confidence, based on ETSI-ITS-CDDAltitude)latitude_value,longitude_value,altitude_valueare standalone integer$defswith ETSI WGS84 bounds (renamed fromlatitude_position,longitude_position,altitude_positionper reviewer comments)reference_positionuses$refforlatitude,longitude,altitudeandposition_confidence_ellipsekinematics_characteristicsis an empty object{ "type": "object", "properties": {}, "additionalProperties": false }, referenced via$refin bothadvised_trr_containerand sub-manoeuvres container