Fix the telemetry setup inherited from the service template - #2
Merged
Merged
Conversation
- Start no exporter when LOGGING_LOGS_URL or LOGGING_METRICS_URL is blank. A blank endpoint resolved to http://localhost:4318, so every staging container ran a 15 s export loop and an OTLP log handler against nothing. - Pass the OTLP exporter timeout in seconds: the 5000 meant as milliseconds gave the exporters an 83-minute HTTP timeout. - Set service.instance.id (the container HOSTNAME) so replicas stop merging their metric streams. - Flush logs and metrics at exit within Docker's 10 s stop grace, ahead of the SDK's 30 s handler, then detach the OTLP log handler. Every container printed "can't create new thread at interpreter shutdown" on stop. - .env.*.exemple: every container needs the LOGGING_* values; blank is inert. - tests/test_tracing_guard.py pins each fix. Build workflow path filters - Both workflows watched the dead algorithms/ instead of simulation/, so a change to the simulation code merged without a new image. - tests/test_build_workflow_paths.py fails when a directory an image's Dockerfile COPYs is missing from the push or pull_request paths of the workflow that builds it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build workflow path filters