fix: make the empty state artwork a background image - #212
Merged
Conversation
An <img> could be dragged by the browser, which blocked drops onto the middle of the empty page.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "no files or folders" illustration was an
<img>, so the browser let you pick it up and drag it around. Dropping files onto the middle of the empty page, which is exactly where the artwork sits, started an image drag instead of an upload.It is a background image now, which the browser will not drag, and the empty state block ignores pointer events so the dropzone underneath gets the drag wherever you aim it. Layout is unchanged.