Skip to content

Bump soroban_sdk and docs fixes#749

Merged
brozorec merged 5 commits into
mainfrom
bump-sdk-and-docs
Jun 10, 2026
Merged

Bump soroban_sdk and docs fixes#749
brozorec merged 5 commits into
mainfrom
bump-sdk-and-docs

Conversation

@brozorec

@brozorec brozorec commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Documentation

    • Clarified Confidential Token compliance documentation regarding account freeze behavior and which accounts are checked during operations.
    • Standardized design documentation formatting and presentation of contract-bound address field identifiers.
    • Updated UltraHonk verifier module backend repository references.
  • Chores

    • Updated Soroban SDK dependency to version 26.1.0.

@brozorec brozorec requested a review from ozgunozerk June 10, 2026 12:24
@brozorec brozorec self-assigned this Jun 10, 2026
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2cf6f40c-e916-45e3-a3c4-0db8da4b2e2b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

This PR updates the confidential token system with a soroban-sdk dependency bump to 26.1.0, migrates UltraHonk backend documentation links to the NethermindEth repository, clarifies compliance documentation on freeze scope targeting, and standardizes DESIGN documentation formatting by escaping address field identifiers throughout.

Changes

Confidential Token Updates

Layer / File(s) Summary
Soroban SDK dependency version bump
Cargo.toml
Workspace dependency on soroban-sdk is updated from version 26.0.0 to 26.1.0 with existing features preserved.
UltraHonk backend documentation migration
packages/tokens/src/confidential/README.md, packages/tokens/src/confidential/verifier/mod.rs
Module-level and README documentation links for the rs-soroban-ultrahonk backend are updated from the Oghma organization to the NethermindEth organization.
Compliance documentation clarification
packages/tokens/src/confidential/docs/COMPLIANCE.md
Compliance documentation is clarified to specify that check_not_frozen targets only the sender and recipient accounts, removing any prior implication of spender account involvement.
DESIGN documentation formatting standardization
packages/tokens/src/confidential/docs/DESIGN.md
Address field identifier addr_f is escaped to addr\_f throughout key-derivation formulas, circuit constraints (Register, Withdraw, Transfer, SetSpender, RevokeSpender), and public-input tables for consistent markdown rendering.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Suggested reviewers

  • ozgunozerk
  • bidzyyys

🐰 Dependencies dance and docs align,
UltraHonk's new home shines bright and fine,
Addresses escape their markdown plight,
Compliance flows clear—everything right! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided by the author, but the template requires description and checklist items for new features and documentation changes. Add a pull request description explaining the changes, reference any related issues, and complete the PR checklist items (Tests and Documentation).
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Bump soroban_sdk and docs fixes' accurately describes the main changes: a dependency version bump and documentation updates across multiple files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bump-sdk-and-docs

Comment @coderabbitai help to get the list of available commands and usage tips.

@brozorec brozorec force-pushed the bump-sdk-and-docs branch from 5522a66 to 919286b Compare June 10, 2026 12:49
@brozorec brozorec force-pushed the bump-sdk-and-docs branch from 96efa4a to 5eba839 Compare June 10, 2026 15:39
@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.62%. Comparing base (1fd1b5f) to head (fb7b84c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #749   +/-   ##
=======================================
  Coverage   96.62%   96.62%           
=======================================
  Files          71       71           
  Lines        7468     7468           
=======================================
  Hits         7216     7216           
  Misses        252      252           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brozorec brozorec merged commit 62016c7 into main Jun 10, 2026
9 checks passed
@brozorec brozorec deleted the bump-sdk-and-docs branch June 10, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants