Skip to content

fix(ci): build the Linux AppImage on debian:11 (fixes red nightly) - #108

Merged
NonPolynomialTim merged 1 commit into
mainfrom
fix/ci-linux-appimage-jsoncpp
Jul 31, 2026
Merged

fix(ci): build the Linux AppImage on debian:11 (fixes red nightly)#108
NonPolynomialTim merged 1 commit into
mainfrom
fix/ci-linux-appimage-jsoncpp

Conversation

@NonPolynomialTim

Copy link
Copy Markdown
Collaborator

Follow-up to #107. The post-merge nightly's build-linux failed to compile:

src/Battlescape/BattlescapeState.cpp:2977: conversion from 'uint64_t' to 'Json::Value' is ambiguous

ubuntu:20.04 ships jsoncpp 1.7.4 (built without JSON_HAS_INT64), so uint64_t is ambiguous between the Int/UInt/double ctors. ubuntu-latest had jsoncpp 1.9.5 and compiled fine; the container migration in #107 regressed it. The AppImage step never even ran.

Fix: build on debian:11 (bullseye) in both ci-main and the ci-validate gate — same low glibc floor (2.31, covers Debian 11+/Ubuntu 20.04+/RHEL·Rocky 9) but modern jsoncpp 1.9.4 + gcc 10, which build the code like ubuntu-latest did.

Net diff vs main is just the container: swap. build-linux isn't a required check, so do not auto-merge — confirm this PR's build-linux is green (it compiles the AppImage on debian:11) before landing, so main's nightly isn't broken again.

🤖 Generated with Claude Code

@NonPolynomialTim
NonPolynomialTim enabled auto-merge (squash) July 31, 2026 02:39
…read)

Rebuilt as a single clean delta on top of main (the branch predated #107's
squash, so its old pre-squash AppImage commits conflicted with main).

build-linux now: debian:11 (glibc 2.31 floor) + jsoncpp 1.9.5 built from
source into /usr/local (distro 1.9.4/1.7.4 makes the coop code's raw
int64/uint64 -> Json::Value writes ambiguous on gcc) + -pthread (glibc
2.31 has a separate libpthread the CMake build never links). Validated
green end-to-end via a branch ci-main dispatch. Mirrored into ci-validate.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@NonPolynomialTim
NonPolynomialTim force-pushed the fix/ci-linux-appimage-jsoncpp branch from f1b5d51 to ab9fc6e Compare July 31, 2026 02:44
@NonPolynomialTim
NonPolynomialTim merged commit 1e3029d into main Jul 31, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant