ci: release build_tests install the test extra - #188
Conversation
The release-workflow.yml build_tests job was using install_extras: "audio,pydantic", which is narrower than the extras needed by the test suite. test_golden.py requires the engines extra (nebulento, ovos-m2v-pipeline), and test_listener_stream.py requires the listener extra (ovos-dinkum-listener). Align with build-tests.yml by installing the full test extra, which is the superset that covers all test dependencies. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Elementary, my dear contributor! The checks are finished. 🕵️♂️I've aggregated the results of the automated checks for this PR below. 📋 Repo HealthEnsuring the repository stays strong and healthy. 💪 ✅ All required files present. Latest Version: ✅ 🏷️ Release PreviewI've checked the 'New Features' highlight reel. 📽️ Current:
✅ PR title follows conventional commit format. 🚀 Release Channel Compatibility Predicted next version:
🔍 LintChecking if we've met all our check criteria. ✅ ❌ ruff: issues found — see job log 🔒 Security (pip-audit)Ensuring our cookies are secure and fresh. 🍪 ✅ No known vulnerabilities found (129 packages scanned). ⚖️ License CheckScanning for any hidden proprietary blobs. 🌑 ✅ No license violations found. Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed. 📊 CoverageA deep dive into the sea of test results. 🌊 Files below 80% coverage (15 files)
Full report: download the 🔨 Build TestsTesting the assembly line for your latest changes. 🏭 ✅ All versions pass
Your 24/7 automated code reviewer 🌙 |
The release-workflow.yml build_tests job was configured to install only the "audio,pydantic" extras, which is narrower than what the test suite requires. Two test modules import optional dependencies not included in that set: test_golden.py needs the engines extra (nebulento, ovos-m2v-pipeline), and test_listener_stream.py needs the listener extra (ovos-dinkum-listener). This configuration gap was not discovered until the first manual workflow_dispatch run on 2026-09-07 21:29 UTC, which failed 8 tests across all four Python version legs (3.10, 3.11, 3.12, 3.13).
This change aligns the release workflow's build_tests job with the PR-check workflow's build-tests.yml, both now installing the full test extra. The test extra is the superset that covers all test dependencies (audio, pydantic, listener, engines, and the TTS/media/bench utilities), verified in pyproject.toml. Installing test instead of the narrower audio,pydantic set resolves the missing optional dependencies without introducing any new packages beyond what the test suite already expects.