Skip to content

fix: drop ovos-core[lgpl] extra — moved to [plugins] in 3.0.1a1 - #156

Draft
JarbasAl wants to merge 1 commit into
devfrom
fix/ovos-core-plugins-floor
Draft

fix: drop ovos-core[lgpl] extra — moved to [plugins] in 3.0.1a1#156
JarbasAl wants to merge 1 commit into
devfrom
fix/ovos-core-plugins-floor

Conversation

@JarbasAl

@JarbasAl JarbasAl commented Sep 3, 2026

Copy link
Copy Markdown
Member

🤖 Auto-generated by Claude Haiku 4.5 and Claude Opus 5 via Claude Code — NOT human-reviewed. Verify before acting.

Summary

ovos-padatious dropped its libfann dependency and is now pure Apache, so it moved from the [lgpl] extra to the [plugins] extra in ovos-core 3.0.1a1. This PR bumps the dependency floor to match and removes the [lgpl] pin, aligning with ovoscope's prerelease-always policy.

All three matchers (Adapt, Padatious, Padacioso) are reachable through the single [plugins] extra. No lgpl reference survives anywhere in the tree: the engines-extra comment in pyproject.toml and docs/multi-engine-golden.md both claimed padatious and padacioso ship with ovos-core[lgpl,plugins], and pyproject.toml, docs/minicroft.md and docs/prerelease-quirks.md told readers on older cores to add [lgpl] themselves — an extra that no longer exists, below a floor those cores cannot satisfy. All of them now name ovos-core[plugins].

Verified floor version

PyPI metadata for ovos-core 3.0.1a1 confirms padatious moved:

ovos_padatious<3.0.0,>=2.0.1a1; extra == "plugins"
ovos_padatious<3.0.0,>=2.0.1a1; extra == "test"

Earlier versions (2.0.4a2–2.5.0a1) have it under [lgpl] only.

Testing

grep -rn lgpl . over the tree returns nothing. A fresh resolve in a clean venv lands a core satisfying the new floor and emits no missing-extra warning, where the previous pin warned that ovos-core==3.4.3a2 has no extra named lgpl:

$ uv pip show ovos-core
Name: ovos-core
Version: 3.4.3a2

All three matchers resolve as entry points: ovos-padatious-pipeline-plugin, ovos-adapt-pipeline-plugin, ovos-padacioso-pipeline-plugin.

Full suite on the merged tree: 698 passed, 25 skipped.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the fix label Sep 3, 2026
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

Reporting for duty! The automated checks have completed. 🎖️

I've aggregated the results of the automated checks for this PR below.

🔍 Lint

Checking if there's anything else we need to do. 📋

ruff: issues found — see job log

📋 Repo Health

Is the codebase feeling fit today? Let's check. 🏃‍♂️

✅ All required files present.

Latest Version: 1.8.1a1

ovoscope/version.py — Version file
README.md — README
LICENSE — License file
pyproject.toml — pyproject.toml
⚠️ setup.py — setup.py
CHANGELOG.md — Changelog
ovoscope/version.py has valid version block markers

⚖️ License Check

Verifying that everything is above board legally. ⚓

✅ No license violations found.

Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed.

🔒 Security (pip-audit)

Checking if our secrets are actually secret. 🤫

✅ No known vulnerabilities found (129 packages scanned).

🏷️ Release Preview

Ensuring the version bump is correctly calculated. 🔢

Current: 1.8.1a1Next: 1.8.2a1

Signal Value
Label fix
PR title fix: drop ovos-core[lgpl] extra — moved to [plugins] in 3.0.1a1
Bump build

✅ PR title follows conventional commit format.


🚀 Release Channel Compatibility

Predicted next version: 1.8.2a1

Channel Status Note Current Constraint
Stable Not in channel -
Testing Too new (must be <1.0.0) ovoscope>=0.7.2,<1.0.0
Alpha Compatible ovoscope>=1.6.15a1

🔨 Build Tests

The build report has been filed and is ready. 📁

✅ All versions pass

Python Build Install Tests
3.10
3.11
3.12
3.13
3.14

📊 Coverage

A bird's eye view of your test coverage landscape. 🦅

⚠️ 62.8% total coverage

Files below 80% coverage (15 files)
File Coverage Missing lines
ovoscope/simple_listener.py 0.0% 63
ovoscope/version.py 0.0% 5
ovoscope/classic_listener.py 18.2% 117
ovoscope/intent_cases.py 22.3% 153
ovoscope/pytest_plugin.py 47.0% 210
ovoscope/cli.py 47.8% 132
ovoscope/ocp.py 47.9% 61
ovoscope/tts_intelligibility.py 49.0% 102
ovoscope/e2e.py 56.2% 67
ovoscope/media.py 56.7% 101
ovoscope/listener.py 57.1% 127
ovoscope/voice_loop.py 59.0% 119
ovoscope/__init__.py 63.2% 423
ovoscope/audio.py 64.4% 126
ovoscope/media_provider.py 67.6% 23

Full report: download the coverage-report artifact.


Closing the loop on this automated check ♻️

ovos-padatious dropped libfann and is now pure Apache; it moved from
the [lgpl] extra to [plugins] in ovos-core 3.0.1a1. Bump the floor to
3.0.1a1 and remove the lgpl extra pin to reflect the current upstream
split, matching ovoscope's prerelease-always policy.

Verified: ovos-core 3.0.1a1 requires_dist lists
  - ovos_padatious<3.0.0,>=2.0.1a1; extra == "plugins"
  - ovos_padatious<3.0.0,>=2.0.1a1; extra == "test"

All three matchers (Adapt, Padatious, Padacioso) are reachable through
the single [plugins] extra, and the resolver no longer warns that
ovos-core has no extra named lgpl.

No lgpl reference survives in the tree. pyproject.toml's engines-extra
comment and docs/multi-engine-golden.md both said padatious and
padacioso ship with ovos-core[lgpl,plugins], and pyproject.toml,
docs/minicroft.md and docs/prerelease-quirks.md told readers on older
cores to add [lgpl] themselves — an extra that no longer exists, below
a floor those cores cannot satisfy. All now name ovos-core[plugins].

Also clarifies timeout-blame semantics: the trained event carries no
skill_id, so only the intent-registering set can be blamed.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@JarbasAl
JarbasAl force-pushed the fix/ovos-core-plugins-floor branch from 12c4474 to bfb2df4 Compare September 8, 2026 12:03
@github-actions github-actions Bot added fix and removed fix labels Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant