fix: drop ovos-core[lgpl] extra — moved to [plugins] in 3.0.1a1 - #156
fix: drop ovos-core[lgpl] extra — moved to [plugins] in 3.0.1a1#156JarbasAl wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Reporting for duty! The automated checks have completed. 🎖️I've aggregated the results of the automated checks for this PR below. 🔍 LintChecking if there's anything else we need to do. 📋 ❌ ruff: issues found — see job log 📋 Repo HealthIs the codebase feeling fit today? Let's check. 🏃♂️ ✅ All required files present. Latest Version: ✅ ⚖️ License CheckVerifying that everything is above board legally. ⚓ ✅ No license violations found. Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed. 🔒 Security (pip-audit)Checking if our secrets are actually secret. 🤫 ✅ No known vulnerabilities found (129 packages scanned). 🏷️ Release PreviewEnsuring the version bump is correctly calculated. 🔢 Current:
✅ PR title follows conventional commit format. 🚀 Release Channel Compatibility Predicted next version:
🔨 Build TestsThe build report has been filed and is ready. 📁 ✅ All versions pass
📊 CoverageA bird's eye view of your test coverage landscape. 🦅 Files below 80% coverage (15 files)
Full report: download the Closing the loop on this automated check ♻️ |
ovos-padatious dropped libfann and is now pure Apache; it moved from the [lgpl] extra to [plugins] in ovos-core 3.0.1a1. Bump the floor to 3.0.1a1 and remove the lgpl extra pin to reflect the current upstream split, matching ovoscope's prerelease-always policy. Verified: ovos-core 3.0.1a1 requires_dist lists - ovos_padatious<3.0.0,>=2.0.1a1; extra == "plugins" - ovos_padatious<3.0.0,>=2.0.1a1; extra == "test" All three matchers (Adapt, Padatious, Padacioso) are reachable through the single [plugins] extra, and the resolver no longer warns that ovos-core has no extra named lgpl. No lgpl reference survives in the tree. pyproject.toml's engines-extra comment and docs/multi-engine-golden.md both said padatious and padacioso ship with ovos-core[lgpl,plugins], and pyproject.toml, docs/minicroft.md and docs/prerelease-quirks.md told readers on older cores to add [lgpl] themselves — an extra that no longer exists, below a floor those cores cannot satisfy. All now name ovos-core[plugins]. Also clarifies timeout-blame semantics: the trained event carries no skill_id, so only the intent-registering set can be blamed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
12c4474 to
bfb2df4
Compare
Summary
ovos-padatious dropped its libfann dependency and is now pure Apache, so it moved from the
[lgpl]extra to the[plugins]extra in ovos-core 3.0.1a1. This PR bumps the dependency floor to match and removes the[lgpl]pin, aligning with ovoscope's prerelease-always policy.All three matchers (Adapt, Padatious, Padacioso) are reachable through the single
[plugins]extra. Nolgplreference survives anywhere in the tree: the engines-extra comment in pyproject.toml and docs/multi-engine-golden.md both claimed padatious and padacioso ship withovos-core[lgpl,plugins], and pyproject.toml, docs/minicroft.md and docs/prerelease-quirks.md told readers on older cores to add[lgpl]themselves — an extra that no longer exists, below a floor those cores cannot satisfy. All of them now nameovos-core[plugins].Verified floor version
PyPI metadata for ovos-core 3.0.1a1 confirms padatious moved:
Earlier versions (2.0.4a2–2.5.0a1) have it under
[lgpl]only.Testing
grep -rn lgpl .over the tree returns nothing. A fresh resolve in a clean venv lands a core satisfying the new floor and emits no missing-extra warning, where the previous pin warned thatovos-core==3.4.3a2has no extra namedlgpl:All three matchers resolve as entry points: ovos-padatious-pipeline-plugin, ovos-adapt-pipeline-plugin, ovos-padacioso-pipeline-plugin.
Full suite on the merged tree: 698 passed, 25 skipped.