Skip to content

ci: coverage installs the pyproject test extra; drop requirements/test.txt - #631

Draft
openvoiceos-bot wants to merge 1 commit into
devfrom
ci/coverage-uses-test-extra
Draft

openvoiceos-bot wants to merge 1 commit into
devfrom
ci/coverage-uses-test-extra

Conversation

@openvoiceos-bot

Copy link
Copy Markdown
Contributor

🤖 Auto-generated by Claude Opus 5 (claude-opus-5) via Claude Code. It is not reviewed by a human. Examine it before you merge it.

Why

requirements/test.txt is a second test dependency list, and it drifted from pyproject.toml:

requirements/test.txt pyproject.toml test extra
ovos-core >=0.0.8a50 >=2.5.3a1 (needed by test_intent_layers_e2e)
ovoscope >=0.1.0 >=0.1.0
ovos-adapt-parser >=1.4.2a1 >=1.4.2a1
pytest, pytest-cov, ovos-translate-server-plugin yes yes

Only .github/workflows/coverage.yml reads the file. dependabot.yml watches /requirements, so the open dependabot PRs #603 and #604 bump this file and not the extra.

Change

  • coverage.yml: installs with pip install -e .[test], in one step with the system packages. The pytest commands do not change.
  • dependabot.yml: the pip directory is /, where pyproject.toml is.
  • requirements/test.txt is removed. No other file references requirements/.

With this change, #603 and #604 are superseded.

Check

The coverage job runs on a push to dev and on workflow_dispatch, so it does not run on this PR. I ran its two pytest commands locally on Python 3.14 (the workflow's version), in a fresh venv with -e .[test] from this branch:

  • pytest --cov=./ovos_workshop --cov-report xml test/unittests: 728 passed.
  • pytest --cov-append --cov=ovos_workshop --cov-report xml test/end2end: 13 passed.

Both YAML files parse.

🤖 Generated with Claude Code

…t.txt

requirements/test.txt was a second test dependency list that drifted from
pyproject.toml: it pinned ovos-core>=0.0.8a50 against the test extra's
>=2.5.3a1, and ovos-adapt-parser>=1.4.2a1 without the rest of the extra.
Only coverage.yml read it.

coverage.yml now runs `pip install -e .[test]`, and dependabot watches
pyproject.toml at the repository root instead of /requirements.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Elementary, my dear contributor! The checks are finished. 🕵️‍♂️

I've aggregated the results of the automated checks for this PR below.

🔍 Lint

The automated results are now available for your perusal. 📂

ruff: issues found — see job log

📡 Channel Compat — testing

Another day, another successful automated run. 🌅

🚧 Channel unresolvable with this checkout — the repo's dependency floors exceed what the channel pins (fleet finding; see the install log).

Constraints: https://raw.githubusercontent.com/OpenVoiceOS/OpenVoiceOS/main/constraints-testing.txt
Resolved stack: channel-compat-testing artifact (constraints + pip freeze).

🔒 Security (pip-audit)

Scanning for any potential man-in-the-middle risks. 👨‍💻

✅ No known vulnerabilities found (72 packages scanned).

⚖️ License Check

Ensuring our copyright headers are in tip-top shape. ✍️

✅ No license violations found.

Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed.

📡 Channel Compat — stable

The latest findings are now at your fingertips. ⌨️

🚧 Channel unresolvable with this checkout — the repo's dependency floors exceed what the channel pins (fleet finding; see the install log).

Constraints: https://raw.githubusercontent.com/OpenVoiceOS/OpenVoiceOS/main/constraints-stable.txt
Resolved stack: channel-compat-stable artifact (constraints + pip freeze).

🔨 Build Tests

I've put your code through the build grinder. ☕

✅ All versions pass

Python Build Install Tests
3.10
3.11
3.12
3.13
3.14

Processing... Done! Have a productive day! ☕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants