ci: coverage installs the pyproject test extra; drop requirements/test.txt - #631
openvoiceos-bot wants to merge 1 commit into
Conversation
…t.txt requirements/test.txt was a second test dependency list that drifted from pyproject.toml: it pinned ovos-core>=0.0.8a50 against the test extra's >=2.5.3a1, and ovos-adapt-parser>=1.4.2a1 without the rest of the extra. Only coverage.yml read it. coverage.yml now runs `pip install -e .[test]`, and dependabot watches pyproject.toml at the repository root instead of /requirements. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Elementary, my dear contributor! The checks are finished. 🕵️♂️I've aggregated the results of the automated checks for this PR below. 🔍 LintThe automated results are now available for your perusal. 📂 ❌ ruff: issues found — see job log 📡 Channel Compat — testingAnother day, another successful automated run. 🌅 🚧 Channel unresolvable with this checkout — the repo's dependency floors exceed what the channel pins (fleet finding; see the install log). Constraints: https://raw.githubusercontent.com/OpenVoiceOS/OpenVoiceOS/main/constraints-testing.txt 🔒 Security (pip-audit)Scanning for any potential man-in-the-middle risks. 👨💻 ✅ No known vulnerabilities found (72 packages scanned). ⚖️ License CheckEnsuring our copyright headers are in tip-top shape. ✍️ ✅ No license violations found. Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed. 📡 Channel Compat — stableThe latest findings are now at your fingertips. ⌨️ 🚧 Channel unresolvable with this checkout — the repo's dependency floors exceed what the channel pins (fleet finding; see the install log). Constraints: https://raw.githubusercontent.com/OpenVoiceOS/OpenVoiceOS/main/constraints-stable.txt 🔨 Build TestsI've put your code through the build grinder. ☕ ✅ All versions pass
Processing... Done! Have a productive day! ☕ |
Why
requirements/test.txtis a second test dependency list, and it drifted frompyproject.toml:requirements/test.txtpyproject.tomltestextra>=0.0.8a50>=2.5.3a1(needed bytest_intent_layers_e2e)>=0.1.0>=0.1.0>=1.4.2a1>=1.4.2a1Only
.github/workflows/coverage.ymlreads the file.dependabot.ymlwatches/requirements, so the open dependabot PRs #603 and #604 bump this file and not the extra.Change
coverage.yml: installs withpip install -e .[test], in one step with the system packages. The pytest commands do not change.dependabot.yml: the pipdirectoryis/, wherepyproject.tomlis.requirements/test.txtis removed. No other file referencesrequirements/.With this change, #603 and #604 are superseded.
Check
The coverage job runs on a push to
devand onworkflow_dispatch, so it does not run on this PR. I ran its two pytest commands locally on Python 3.14 (the workflow's version), in a fresh venv with-e .[test]from this branch:pytest --cov=./ovos_workshop --cov-report xml test/unittests: 728 passed.pytest --cov-append --cov=ovos_workshop --cov-report xml test/end2end: 13 passed.Both YAML files parse.
🤖 Generated with Claude Code