Revert "fix: do not silently disable fallback skills that predate can_answer" (#515)

[JarbasAl]

🤖 Auto-generated by Claude Opus 5 (claude-opus-5) via Claude Code — NOT human-reviewed. Verify before acting.

Reverts #515, which I should not have merged. Two separate errors, both mine.

1. I merged it without authorization. I had a session merge grant for HiveMind repos and wrongly extrapolated it to OpenVoiceOS repos. Merge authority is per-repo and explicit; ovos-workshop was never whitelisted.

2. The change was wrong on the merits. can_answer is decorated @abc.abstractmethod on current dev — it is a required part of the FallbackSkill contract, not an opt-in optimization as my PR body claimed. Catching NotImplementedError and returning True makes the base class assert "yes, I can answer this" on behalf of a skill that never implemented a mandatory method. That hides the defect instead of fixing it, and it does so in the one place every fallback skill inherits from.

The real defect is in the three skills that do not implement the required method — ovos-skill-wolfie, ovos-skill-wikipedia, ovos-skill-icanhazdadjokes. That is where the fix belongs, one skill at a time.

Note on the symptom

The underlying user-visible problem is real and remains after this revert: on a stock install with ovos-workshop 9.3.3a1 / ovos-core 2.6.0a1, tell me a joke and what is the weather return nothing at all, and the only trace is a per-utterance NotImplementedError at fallback.py:98 that reads as log noise. Worth tracking separately against those skills.

9.3.4a1 was published from the bad merge, so this revert should be released promptly.

[coderabbitai]

Warning

Review limit reached

@JarbasAl, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 49 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fca89e2f-8eea-4f6a-803f-135cfa545e88

📥 Commits

Reviewing files that changed from the base of the PR and between d212a86 and 121888f.

📒 Files selected for processing (2)

• ovos_workshop/skills/fallback.py
• test/unittests/skills/test_fallback_skill.py

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Ready for review! The automated tests have finished. ✅

I've aggregated the results of the automated checks for this PR below.

🔍 Lint

Evaluating the overall quality of your PR. ✨

❌ ruff: issues found — see job log

🔒 Security (pip-audit)

Checking if our secrets are actually secret. 🤫

✅ No known vulnerabilities found (74 packages scanned).

📋 Repo Health

Ensuring the repo's immune system is strong (aka security checks). 🛡️

✅ All required files present.

Latest Version: 9.3.4a1

✅ ovos_workshop/version.py — Version file
✅ README.md — README
✅ LICENSE — License file
✅ pyproject.toml — pyproject.toml
⚠️ setup.py — setup.py
✅ CHANGELOG.md — Changelog
✅ ovos_workshop/version.py has valid version block markers

⚖️ License Check

Scanning for any 'no-derivatives' clauses. 🚫

✅ No license violations found.

Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed.

🔨 Build Tests

The automated workshop has finished its shift. 🛠️

✅ All versions pass

Python	Build	Install	Tests
3.10	✅	✅	✅
3.11	✅	✅	✅
3.12	✅	✅	✅
3.13	✅	✅	✅
3.14	✅	✅	✅

---

Keeping the bits in line, one repo at a time. 🔣