Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Pardon the interruption, but your automated checks are ready! 🛎️I've aggregated the results of the automated checks for this PR below. 📋 Repo HealthHealth report: The repository is thriving! 🌟 ✅ All required files present. Latest Version: ✅ 🔍 LintGeneric report status: Complete and verified. ✅ ❌ ruff: issues found — see job log 🔨 Build TestsBuild test complete! Let's see if everything fits together. 🧩 ✅ All versions pass
⚖️ License CheckChecking for any potential license conflicts. ⚔️ ✅ No license violations found. Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed. 🔒 Security (pip-audit)I've checked the firewalls of your PR. 🔥 ✅ No known vulnerabilities found (74 packages scanned). An automated high-five for your latest changes! 🖐️ |
2dc78a2 to
476343b
Compare
- import GUIInterface from ovos_gui_api_client (extracted, standalone) in skills/ovos.py and app.py instead of ovos_bus_client.apis.gui - SkillGUI no longer passes the obsolete ui_directories arg (skills no longer ship QML); drop get_ui_directories import - drop explicit setup_default_handlers() call (the new GUIInterface wires its default handlers in __init__) - add ovos-gui-api-client dependency; install it from git in CI until released - unit tests for the rebind (subclassing, construction, template emit, bus contract)
ovos-gui-api-client 0.1.0 is now on PyPI and pulled in via the normal pyproject dependency; the git-ref pre-install step is no longer needed and git refs break PyPI publish.
476343b to
4d43eb9
Compare
Bind
OVOSSkill.guito the standaloneovos-gui-api-clientPart of the GUI rework. The skill-side
GUIInterfacehas beenextracted from
ovos-bus-clientinto the standaloneovos-gui-api-clientpackage. This PR points workshop at it.
Changes
skills/ovos.py+app.py: importGUIInterfacefromovos_gui_api_client(was
ovos_bus_client.apis.gui).SkillGUI.__init__: drop the obsoleteui_directoriesargument — skills nolonger ship QML, so there are no UI directories to locate. Removes the
get_ui_directoriesimport._init_skill_gui: drop the explicitsetup_default_handlers()call; the newGUIInterfacewires its default handlers in__init__.pyproject.toml:ovos-gui-api-client>=0.1.0,<1.0.0.Tests
test/unittests/test_gui_rebind.py— 5 tests: workshop imports the api-clientinterface,
SkillGUIsubclasses it, constructs withoutui_directories,show_text()emitsgui.page.show(SYSTEM_text), and the no-bus contract.CI / dependency note
ovos-gui-api-clientis now published on PyPI (0.1.0) — the git-refpre_install_pip/ explicit git-install CI step has been dropped in favor ofthe normal versioned dependency.
2026-07-24 rebase onto dev
Rebased onto current
dev(post #431 INTENT-4 producer, #483/#485/#486resource-shim + gate rewrite, #480 EnclosureAPI→ovos-gui-api-client import).
One real conflict, in
pyproject.toml: dev's #480 had already addedovos-gui-api-client>=0.1.0,<1.0.0forEnclosureAPI; kept dev's (published)version bound and updated the comment to cover both
EnclosureAPIandGUIInterface.skills/ovos.pyauto-merged cleanly (dev'sEnclosureAPIimport + this PR's
GUIInterfaceimport coexist). Dropped the now-unneededgit-ref CI install (package is on PyPI as of 0.1.0) in a follow-up commit.
Full local test suite: 558 passed, 2 known-failing (pre-existing on bare
dev, unrelated to this PR:test_inline_vocab_refs::test_padacioso_raw_reference_is_rejectedand
test_decorators::TestKillableIntents::test_get_response, the latter onlyfails when unittests+end2end run together — test-order pollution, reproduced
on bare
devtoo).Depends on: ovos-gui-api-client#2 (merged, released as 0.1.0). Draft until reviewed.