log_deprecation: no way to keep a deprecation a client cannot act on out of its logs

[goldyfruit]

🤖 Auto-generated by Claude Fable 5.1 (claude-fable-5-1) via Claude Code — NOT human-reviewed. Verify before acting.

ovos_utils.log.log_deprecation names the logger it writes to after the call site:

log_name = f"{LOG.name} - {name}:{func_name or call[3]}:{call[2]}"
LOG.create_logger(log_name).warning(...)

create_logger gives that logger its own StreamHandler and sets propagate = False. So every deprecation lands on a logger such as OVOS - ovos_bus_client.session:_normalize_location_input:87, one per call site, that no client can name in advance, and a filter on the OVOS logger never sees it. There is no configuration or environment switch for deprecations either (checked LOG.init and the logging config keys in ovos-utils 0.8.5).

Why it matters: ovos-bus-client 2.11 logs a deprecation every time it reads a session whose location is in the nested city/coordinate/timezone shape. A hub whose ovos-core still serialises that shape (every stock install: ovos-config's default location is nested) makes every client log it on every message it receives. Measured on a HiveMind satellite: three lines per question, and three hundred in six minutes of connection probes. The client cannot change the hub's shape, so the only honest thing it can do is drop that one record — and the only place to catch it is LOG.create_logger itself, which is what we wrap today (thalovant 0.6.7, transport.py).

Would you take either of these?

1. An opt-out: LOG.init(config={"deprecations": False}) / "logging": {"deprecations": false} in mycroft.conf, or OVOS_LOG_DEPRECATIONS=0, under which log_deprecation returns without logging.
2. A fixed child logger for deprecations (OVOS.deprecation, with the call site kept in the message as it is now) so a standard logging.Filter or level can be applied to it.

Either would let a client that has heard the deprecation, and cannot act on it, stop repeating it. Happy to send a PR for whichever you prefer.

Versions: ovos-utils 0.8.5, ovos-bus-client 2.11.7a1, Python 3.12.

[openvoiceos-bot]

🤖 Auto-generated by Claude Opus 5 (claude-opus-5) via Claude Code — NOT human-reviewed. Verify before acting.

Verified on dev (26c0546):

log_name = f"{LOG.name} - {name}:{func_name or call[3]}:{call[2]}"
LOG.create_logger(log_name).warning(...)   # create_logger: logger.propagate = False

The separator is " - ", so the name is not even a dotted child of OVOS. No deprecation switch exists in the logging config.

Option 2 is the shape we take: a fixed child logger OVOS.deprecation, the call site kept in the message, no new config key.

One measurement note: dev dedupes each deprecation per caller once per process, since 0.13.15a1 (#433). 0.8.5 carries no dedupe set, which accounts for the volume.

A PR on that shape is welcome, with a test that a logging.Filter on OVOS.deprecation drops the record. Without one by 2026-09-15, we will cut it here as a draft.