Skip to content

fix: it-IT failed_extract_number dialog never rendered - #71

Closed
JarbasAl wants to merge 1 commit into
devfrom
fix/it-it-failed-extract-number
Closed

JarbasAl wants to merge 1 commit into
devfrom
fix/it-it-failed-extract-number

Conversation

@JarbasAl

@JarbasAl JarbasAl commented Sep 9, 2026

Copy link
Copy Markdown
Member

🤖 Auto-generated by Claude Opus 5 (claude-opus-5) via Claude Code — NOT human-reviewed. Verify before acting.

The skill only ever speaks self.speak_dialog("failed_extract_number") when it cannot extract a number from the utterance. Fourteen of fifteen locales ship a failed_extract_number.dialog; it-IT instead shipped a stale count_to_N.error.dialog that the code never references. An Italian user who hits that failure path got no spoken dialog at all — the resource lookup silently fell back to a different locale's file instead. The two Italian lines were already correct translations, so this is a rename only (git mv), byte-for-byte, no rewording.

Checked all fifteen locale directories; it-IT is the only one missing failed_extract_number.dialog.

Fail-before, run against the tree before the rename:

test/unittests/test_intent_resource_locale.py::TestIntentResourceLocale::test_it_it_failed_extract_number_dialog_renders_italian_text FAILED
AssertionError: 'it-IT' not found in '/home/miro/tmp/count-itit-clone/ovos_skill_count/locale/ca-ES/failed_extract_number.dialog' : resolved /home/miro/tmp/count-itit-clone/ovos_skill_count/locale/ca-ES/failed_extract_number.dialog instead of the it-IT resource
1 failed, 1 passed

After the rename:

test/unittests/test_intent_resource_locale.py::TestIntentResourceLocale::test_it_it_count_to_n_intent_resolves_to_italian_file PASSED
test/unittests/test_intent_resource_locale.py::TestIntentResourceLocale::test_it_it_failed_extract_number_dialog_renders_italian_text PASSED
2 passed

The rename also fixes an OVOS-INTENT-2 §2 violation: "A resource base name MUST consist only of lowercase ASCII letters, digits, and underscores, and MUST NOT contain whitespace; file extensions are likewise lowercase." count_to_N.error carries both an uppercase letter and an extra dot, breaking that MUST twice; the new name is compliant.

@github-actions github-actions Bot added the fix label Sep 9, 2026
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

I've finished my rounds! Here's the state of the PR. 🏥

I've aggregated the results of the automated checks for this PR below.

🎙️ Skill

I've audited the skill's permission requests. 🔒

ℹ️ Not an OVOS skill repo — check skipped.

📋 Repo Health

The repo's annual physical is complete! 🩺

✅ All required files present.

Latest Version: 0.2.0a1

✅ ovos_skill_count/version.py — Version file
✅ README.md — README
✅ LICENSE — License file
⚠️ pyproject.toml — pyproject.toml
✅ setup.py — setup.py
✅ CHANGELOG.md — Changelog
✅ requirements.txt — Requirements
✅ ovos_skill_count/version.py has valid version block markers

⚖️ License Check

Scanning for any 'no-derivatives' clauses. 🚫

✅ No license violations found.

Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed.

🔨 Build Tests

The build pipeline has finished its work. 🏁

✅ All versions pass

Python Build Install Tests
3.10 ✅ ✅ ✅
3.11 ✅ ✅ ✅
3.12 ✅ ✅ ✅
3.13 ✅ ✅ ✅
3.14 ✅ ✅ ✅

🧪 Spec Lint

Evaluating the overall progress of your contribution. 📉

ℹ️ locale folder locale not found — spec-lint skipped.

🔒 Security (pip-audit)

Scanning for any potential privilege escalations. 🪜

✅ No known vulnerabilities found (73 packages scanned).

🔌 Skill Tests (ovoscope)

I've analyzed the semantic resonance of your dialogs. 🔊

✅ 26/26 passed

✅ TestCountIntents — 2/2
✅ TestCountSkills — 3/3
✅ TestStopNoSkills — 3/3
✅ test_golden_utterance[can you count to five] — 1/1
✅ test_golden_utterance[count forever in long scale] — 1/1
✅ test_golden_utterance[count forever in short scale] — 1/1
✅ test_golden_utterance[count forever using long scale] — 1/1
✅ test_golden_utterance[count forever using short scale] — 1/1
✅ test_golden_utterance[count forever] — 1/1
✅ test_golden_utterance[count from one to twenty] — 1/1
✅ test_golden_utterance[count to 20] — 1/1
✅ test_golden_utterance[count to 3 in long scale] — 1/1
✅ test_golden_utterance[count to five using ordinal numbers] — 1/1
✅ test_golden_utterance[count to ten] — 1/1
✅ test_negative_confusable_not_claimed[are you ready] — 1/1
✅ test_negative_confusable_not_claimed[launch spotify] — 1/1
✅ test_negative_confusable_not_claimed[set a timer for 5 minutes] — 1/1
✅ test_negative_confusable_not_claimed[take a picture] — 1/1
✅ test_negative_confusable_not_claimed[what color is something] — 1/1
✅ test_negative_confusable_not_claimed[what happened today in history] — 1/1
✅ test_negative_confusable_not_claimed[what's the weather] — 1/1

🚌 Bus Coverage

Is the code wearing its bus-suit? Let's see. 👔

⚠️ Bus coverage report unavailable — check the job log.

🏷️ Release Preview

Evaluating the excitement level for the next release. 🤩

Current: 0.2.0a1 → Next: 0.2.1a1

Signal Value
Label fix
PR title fix: it-IT failed_extract_number dialog never rendered
Bump build

✅ PR title follows conventional commit format.


🚀 Release Channel Compatibility

Predicted next version: 0.2.1a1

Channel Status Note Current Constraint
Stable ⚪ Not in channel -
Testing ✅ Compatible ovos-skill-count>=0.0.2,<1.0.0
Alpha ✅ Compatible ovos-skill-count>=0.2.0a1

📊 Coverage

Measuring the breadth of our automated checks. 📏

❌ 25.0% total coverage

Per-file coverage (2 files)
File Coverage Missing lines
ovos_skill_count/version.py 0.0% 4
ovos_skill_count/__init__.py 26.6% 47

Full report: download the coverage-report artifact.

🔍 Lint

A detailed summary of the latest automation run. 📝

✅ ruff: no issues


Your friendly neighborhood bot 🕷️

…alog

The skill only ever speaks self.speak_dialog("failed_extract_number").
Fourteen of fifteen locales ship failed_extract_number.dialog; it-IT
instead shipped a stale count_to_N.error.dialog that the code never
speaks, so an Italian user who triggers the number-extraction failure
path got no dialog rendered at all. The two Italian lines were already
correct translations, so this is a rename only, preserving both lines
byte-for-byte and following history via git mv.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@JarbasAl
JarbasAl force-pushed the fix/it-it-failed-extract-number branch from 9d10e4d to 9f0c069 Compare September 9, 2026 21:36
@JarbasAl JarbasAl closed this Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant