Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
I've finished my rounds! Here's the state of the PR. 🏥I've aggregated the results of the automated checks for this PR below. 🎙️ SkillI've audited the skill's permission requests. 🔒 ℹ️ Not an OVOS skill repo — check skipped. 📋 Repo HealthThe repo's annual physical is complete! 🩺 ✅ All required files present. Latest Version: ✅ ⚖️ License CheckScanning for any 'no-derivatives' clauses. 🚫 ✅ No license violations found. Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed. 🔨 Build TestsThe build pipeline has finished its work. 🏁 ✅ All versions pass
🧪 Spec LintEvaluating the overall progress of your contribution. 📉 ℹ️ locale folder locale not found — spec-lint skipped. 🔒 Security (pip-audit)Scanning for any potential privilege escalations. 🪜 ✅ No known vulnerabilities found (73 packages scanned). 🔌 Skill Tests (ovoscope)I've analyzed the semantic resonance of your dialogs. 🔊 ✅ 26/26 passed ✅ TestCountIntents — 2/2 🚌 Bus CoverageIs the code wearing its bus-suit? Let's see. 👔 🏷️ Release PreviewEvaluating the excitement level for the next release. 🤩 Current:
✅ PR title follows conventional commit format. 🚀 Release Channel Compatibility Predicted next version:
📊 CoverageMeasuring the breadth of our automated checks. 📏 ❌ 25.0% total coverage Per-file coverage (2 files)
Full report: download the 🔍 LintA detailed summary of the latest automation run. 📝 ✅ ruff: no issues Your friendly neighborhood bot 🕷️ |
…alog
The skill only ever speaks self.speak_dialog("failed_extract_number").
Fourteen of fifteen locales ship failed_extract_number.dialog; it-IT
instead shipped a stale count_to_N.error.dialog that the code never
speaks, so an Italian user who triggers the number-extraction failure
path got no dialog rendered at all. The two Italian lines were already
correct translations, so this is a rename only, preserving both lines
byte-for-byte and following history via git mv.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
9d10e4d to
9f0c069
Compare
The skill only ever speaks
self.speak_dialog("failed_extract_number")when it cannot extract a number from the utterance. Fourteen of fifteen locales ship afailed_extract_number.dialog; it-IT instead shipped a stalecount_to_N.error.dialogthat the code never references. An Italian user who hits that failure path got no spoken dialog at all — the resource lookup silently fell back to a different locale's file instead. The two Italian lines were already correct translations, so this is a rename only (git mv), byte-for-byte, no rewording.Checked all fifteen locale directories; it-IT is the only one missing
failed_extract_number.dialog.Fail-before, run against the tree before the rename:
After the rename:
The rename also fixes an OVOS-INTENT-2 §2 violation: "A resource base name MUST consist only of lowercase ASCII letters, digits, and underscores, and MUST NOT contain whitespace; file extensions are likewise lowercase."
count_to_N.errorcarries both an uppercase letter and an extra dot, breaking that MUST twice; the new name is compliant.