fix: name the it-IT error dialog the way the skill speaks it - #70
fix: name the it-IT error dialog the way the skill speaks it#70JarbasAl wants to merge 1 commit into
Conversation
it-IT shipped its translation as count_to_N.error.dialog while speak_dialog asks for failed_extract_number, so Italian users heard the en-US line.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The results of your automated verification are here! 📜I've aggregated the results of the automated checks for this PR below. 🎙️ SkillChecking if this skill has all its ducks in a row. 🦆 ℹ️ Not an OVOS skill repo — check skipped. 📊 CoverageI've mapped out the test coverage for you! 🗺️ ❌ 26.1% total coverage Per-file coverage (2 files)
Full report: download the 📋 Repo HealthI've performed a health check on the project. 🏥 ✅ All required files present. Latest Version: ✅ ⚖️ License CheckKeeping the lawyers happy, one file at a time. 👔 ✅ No license violations found. Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed. 🔒 Security (pip-audit)I've checked the firewalls of your PR. 🔥 ✅ No known vulnerabilities found (73 packages scanned). 🏷️ Release PreviewComing soon to a stable branch near you! 📽️ Current:
✅ PR title follows conventional commit format. 🚀 Release Channel Compatibility Predicted next version:
🔍 LintEnsuring we're following our development process. 📏 ❌ ruff: issues found — see job log 🔌 Skill Tests (ovoscope)I ran the end-to-end skill tests to see how your skill behaves in the real world! 🎤 ✅ 26/26 passed ✅ TestCountIntents — 2/2 🚌 Bus CoverageMeasuring the reach of our bus handlers. 📏 🔨 Build TestsEverything is bolted down and ready to go. 🔩 ✅ All versions pass
Closing the loop on this automated check ♻️ |
it-IT is the one locale that never speaks its own error line. Its translation lives in
count_to_N.error.dialog, a name the skill stopped asking for; every other locale ships it asfailed_extract_number.dialog, which is whatspeak_dialognames. An Italian user who asks the skill to count to something it cannot parse is answered in English, from the en-US fallback, while the Italian sentence sits unused in the tree.One rename. The Italian text is untouched, and it says what the en-US line says: it did not understand which number to count up to.
test_resource_names.pyasserts every shipped.dialogis named by aspeak_dialogand every.intentby an@intent_handler. It fails ondevon the dialog check and passes here. Suite: 9 passed.