Skip to content

fix: name the it-IT error dialog the way the skill speaks it - #70

Draft
JarbasAl wants to merge 1 commit into
devfrom
fix/it-it-dialog-name
Draft

fix: name the it-IT error dialog the way the skill speaks it#70
JarbasAl wants to merge 1 commit into
devfrom
fix/it-it-dialog-name

Conversation

@JarbasAl

@JarbasAl JarbasAl commented Sep 8, 2026

Copy link
Copy Markdown
Member

🤖 Auto-generated by Claude Opus 5 (claude-opus-5) via Claude Code — NOT human-reviewed. Verify before acting.

it-IT is the one locale that never speaks its own error line. Its translation lives in count_to_N.error.dialog, a name the skill stopped asking for; every other locale ships it as failed_extract_number.dialog, which is what speak_dialog names. An Italian user who asks the skill to count to something it cannot parse is answered in English, from the en-US fallback, while the Italian sentence sits unused in the tree.

One rename. The Italian text is untouched, and it says what the en-US line says: it did not understand which number to count up to.

test_resource_names.py asserts every shipped .dialog is named by a speak_dialog and every .intent by an @intent_handler. It fails on dev on the dialog check and passes here. Suite: 9 passed.

it-IT shipped its translation as count_to_N.error.dialog while
speak_dialog asks for failed_extract_number, so Italian users heard the
en-US line.
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

The results of your automated verification are here! 📜

I've aggregated the results of the automated checks for this PR below.

🎙️ Skill

Checking if this skill has all its ducks in a row. 🦆

ℹ️ Not an OVOS skill repo — check skipped.

📊 Coverage

I've mapped out the test coverage for you! 🗺️

26.1% total coverage

Per-file coverage (2 files)
File Coverage Missing lines
ovos_skill_count/version.py 0.0% 4
ovos_skill_count/__init__.py 27.7% 47

Full report: download the coverage-report artifact.

📋 Repo Health

I've performed a health check on the project. 🏥

✅ All required files present.

Latest Version: 0.2.0a1

ovos_skill_count/version.py — Version file
README.md — README
LICENSE — License file
⚠️ pyproject.toml — pyproject.toml
setup.py — setup.py
CHANGELOG.md — Changelog
requirements.txt — Requirements
ovos_skill_count/version.py has valid version block markers

⚖️ License Check

Keeping the lawyers happy, one file at a time. 👔

✅ No license violations found.

Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed.

🔒 Security (pip-audit)

I've checked the firewalls of your PR. 🔥

✅ No known vulnerabilities found (73 packages scanned).

🏷️ Release Preview

Coming soon to a stable branch near you! 📽️

Current: 0.2.0a1Next: 0.2.1a1

Signal Value
Label (none)
PR title fix: name the it-IT error dialog the way the skill speaks it
Bump build

✅ PR title follows conventional commit format.


🚀 Release Channel Compatibility

Predicted next version: 0.2.1a1

Channel Status Note Current Constraint
Stable Not in channel -
Testing Compatible ovos-skill-count>=0.0.2,<1.0.0
Alpha Compatible ovos-skill-count>=0.2.0a1

🔍 Lint

Ensuring we're following our development process. 📏

ruff: issues found — see job log

🔌 Skill Tests (ovoscope)

I ran the end-to-end skill tests to see how your skill behaves in the real world! 🎤

26/26 passed

TestCountIntents — 2/2
TestCountSkills — 3/3
TestStopNoSkills — 3/3
test_golden_utterance[can you count to five] — 1/1
test_golden_utterance[count forever in long scale] — 1/1
test_golden_utterance[count forever in short scale] — 1/1
test_golden_utterance[count forever using long scale] — 1/1
test_golden_utterance[count forever using short scale] — 1/1
test_golden_utterance[count forever] — 1/1
test_golden_utterance[count from one to twenty] — 1/1
test_golden_utterance[count to 20] — 1/1
test_golden_utterance[count to 3 in long scale] — 1/1
test_golden_utterance[count to five using ordinal numbers] — 1/1
test_golden_utterance[count to ten] — 1/1
test_negative_confusable_not_claimed[are you ready] — 1/1
test_negative_confusable_not_claimed[launch spotify] — 1/1
test_negative_confusable_not_claimed[set a timer for 5 minutes] — 1/1
test_negative_confusable_not_claimed[take a picture] — 1/1
test_negative_confusable_not_claimed[what color is something] — 1/1
test_negative_confusable_not_claimed[what happened today in history] — 1/1
test_negative_confusable_not_claimed[what's the weather] — 1/1

🚌 Bus Coverage

Measuring the reach of our bus handlers. 📏

⚠️ Bus coverage report unavailable — check the job log.

🔨 Build Tests

Everything is bolted down and ready to go. 🔩

✅ All versions pass

Python Build Install Tests
3.10
3.11
3.12
3.13
3.14

Closing the loop on this automated check ♻️

@github-actions github-actions Bot added the fix label Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant