spec(intent-4): a registration omitting a required identity field is malformed - #261
Draft
openvoiceos-bot wants to merge 1 commit into
Draft
spec(intent-4): a registration omitting a required identity field is malformed#261openvoiceos-bot wants to merge 1 commit into
openvoiceos-bot wants to merge 1 commit into
Conversation
…malformed and is never repaired Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decision for Miro: this adds a MUST to INTENT-4 §3.2 and merges only on his yes.
INTENT-4 marks
skill_id,intent_name/entity_nameandlangrequired in the §3.2 table but says nothing about what a consumer does when one is absent; the malformed set in §5.3, §6.3, §7.2 and §12 covers constraints, samples and reserved names only. The new paragraph closes that: a message of §§5–8 omitting a required identity field is malformed, a consumer MUST NOT index or act on it, MUST NOT derive the value from context, topic or another field, and MUST log the rejection at WARN naming the missing field. CHANGELOG entry under INTENT-4.What it codifies, measured by the harness lane on a real bus: adapt, padatious and m2v already reject an unattributed registration and WARN. padacioso accepts it and derives
skill_idfrom the colon prefix ofintent_name, silently; that is the behaviour this clause forbids, and the fourth implementation is the one the clause exists for.The existing sentence that a message is complete without
context.skill_idis unchanged: the source may be absent, the target may not.Verified against source by model re-check, not human review: engine logs in knowledge/wiki/audits/gate-ledger (harness cells for adapt#76, padatious#153, markov#16); the reading with the silence established by search is knowledge/wiki/audits/architecture/readings-2026-09-09.md §2.