docs(intent-4): §7.1 table restates the entity identity fields - #260
Draft
openvoiceos-bot wants to merge 1 commit into
Draft
docs(intent-4): §7.1 table restates the entity identity fields#260openvoiceos-bot wants to merge 1 commit into
openvoiceos-bot wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INTENT-4 §7.1's field table restates
skill_idandlangas required and says the entity identity is(skill_id, entity_name, lang)with per-language replacement. Both facts already follow from §3.2 ("For an entity,intent_nameis replaced byentity_name" and "Replacement is also per-language"); the table now says so where a reader implementing entity registration looks. Editorial; no normative change, no CHANGELOG entry.Why: two implementations keyed an entity registry on the name alone and let the last language overwrite the others. Both read §7 and neither followed the pointer to §3.2.