docs(divergences): the legacy intent toggle carries no target skill_id - #257
Draft
JarbasAl wants to merge 1 commit into
Draft
docs(divergences): the legacy intent toggle carries no target skill_id#257JarbasAl wants to merge 1 commit into
JarbasAl wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The catalogue row for
mycroft.skill.enable_intent/disable_intentrecords that the legacy payload carries no targetskill_id, so a bridge cannot supply one and a consumer honouring bridged toggles resolves the target fromcontext.skill_idfor the stable cycle.Editorial, catalogue only; no normative text changes, so no CHANGELOG entry.
Verified against source by model re-check, not human review: ovos-spec-tools
ovos_spec_tools/messages.py:552-557at dev 3f116a8 copies onlyintent_namefrom the legacy toggle; ovos-core#969 is the consumer that logs the substitution.