spec: SESSION-2 §3.3 converges on each handled marker of a session - #238
Draft
JarbasAl wants to merge 1 commit into
Draft
spec: SESSION-2 §3.3 converges on each handled marker of a session#238JarbasAl wants to merge 1 commit into
JarbasAl wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
§3.3 says clients adopt the session at
ovos.utterance.handled, "emitted exactly once per utterance" — a claim that made adoption unambiguous because there was only ever one marker to adopt. PIPELINE-1 §6.5 describes a long-running handler that blocks on a follow-up question: the reply runs as a nested, independentovos.utterance.handle/ovos.utterance.handledlifecycle that shares the outer round'ssession_id, and the outer lifecycle's ownovos.utterance.handledfires only after the handler returns. §6.5 states plainly that "no additional correlation field is defined by this specification" beyond the sharedsession_id— so an inner and an outer marker for the same round are session-siblings with nothing that ranks one above the other.The new text keeps the per-lifecycle invariant (
ovos.utterance.handledstill fires exactly once for theovos.utterance.handlethat opened that lifecycle) but drops the false claim that this is exactly once per session, since a nested lifecycle produces a second marker for the same session. The convergence rule becomes: a client converges on everyovos.utterance.handledit receives for its session, in the order it receives them, each one superseding whatever the client held before — aspeak-driven incremental adoption or an earlier marker for the same session.