spec: instant sounds are session-scoped; listener sleep is acknowledged and queryable - #230
Draft
JarbasAl wants to merge 2 commits into
Draft
spec: instant sounds are session-scoped; listener sleep is acknowledged and queryable#230JarbasAl wants to merge 2 commits into
JarbasAl wants to merge 2 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
#164) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
JarbasAl
force-pushed
the
spec/audio-scoped-instant-sounds-acked-sleep
branch
from
September 8, 2026 18:15
a7c9742 to
3883e4e
Compare
JarbasAl
force-pushed
the
spec/audio-scoped-instant-sounds-acked-sleep
branch
from
September 8, 2026 19:06
3883e4e to
4df7848
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AUDIO-IN-1 §6.3 (dev): "Sleep entry is unacknowledged by design: no confirmation Message is emitted on entering sleep." and "No topic in this specification lets a component query current listener state [...]. This is a deliberate omission".
AUDIO-1 §4.1 (dev): "The audio output service MUST only enqueue items whose
context.session.session_idmatches a session it is configured to serve locally."Listener sleep. A controller that puts the listener to sleep gets no confirmation it took effect and has no way to ask. The audio input service now replies to
ovos.listener.sleeponovos.listener.sleep.responseonce sleep mode is entered, and answersovos.listener.sleep.queryonovos.listener.sleep.query.responsewith{asleep: bool}, both through theresponsederivation (OVOS-MSG-1 §5.3). Sleep stays device-wide. Shippedovos-dinkum-listeneremits nothing on sleep and publishes no sleep state, so both are new surface.Instant sounds.
ovos.audio.play_soundgains the §4.1 session scope every other output request carries: the service plays an instant sound only for a session it is configured to serve locally. Instant sounds stay not stoppable, as §4.2 already says: they are short acknowledgement or error cues, and anything longer belongs on the scheduled queue, where it takes its turn with speech and is stoppable there. The §4.2 text now says why.Stacked on #253 (the same file's §6.4 wake request); merges after it.