Skip to content

Minimise fixed point header - #721

Merged
wvpm merged 1 commit into
masterfrom
minimise_fp_header
May 17, 2026
Merged

Minimise fixed point header#721
wvpm merged 1 commit into
masterfrom
minimise_fp_header

Conversation

@wvpm

@wvpm wvpm commented May 11, 2026 •
edited by Spartan322
Loading

Copy link
Copy Markdown
Contributor

@wvpm wvpm added enhancement Issue that describes an improvement to the project topic:codestyle Issue that applies stylistic changes to the module, semantics and mechanics should not change labels May 11, 2026
@wvpm
wvpm marked this pull request as draft May 12, 2026 12:54
@zaaarf

zaaarf commented May 13, 2026

Copy link
Copy Markdown
Member

so far so good

@wvpm
wvpm force-pushed the minimise_fp_header branch 5 times, most recently from 018ac8d to eed2140 Compare May 13, 2026 15:55
@wvpm
wvpm marked this pull request as ready for review May 13, 2026 15:56
@wvpm
wvpm force-pushed the minimise_fp_header branch from ee2141b to c991a1b Compare May 13, 2026 22:56
@wvpm
wvpm requested a review from a team as a code owner May 13, 2026 22:56
Spartan322
Spartan322 reviewed May 13, 2026
View reviewed changes
Comment thread src/openvic-simulation/core/Math.hpp Outdated
Spartan322
Spartan322 reviewed May 13, 2026
View reviewed changes
Comment thread src/openvic-simulation/core/Math.hpp Outdated
Spartan322
Spartan322 reviewed May 13, 2026
View reviewed changes
Comment thread src/openvic-simulation/types/fixed_point/FixedPoint.hpp Outdated
@wvpm
wvpm force-pushed the minimise_fp_header branch from c991a1b to 3949f2d Compare May 13, 2026 23:11
Spartan322
Spartan322 reviewed May 13, 2026
View reviewed changes
Comment thread src/openvic-simulation/types/fixed_point/FixedPoint.hpp Outdated
@wvpm
wvpm force-pushed the minimise_fp_header branch 3 times, most recently from 8895a87 to 219a80d Compare May 13, 2026 23:34
@wvpm
wvpm enabled auto-merge May 13, 2026 23:34
@wvpm
wvpm requested a review from Spartan322 May 14, 2026 08:17
@wvpm wvpm mentioned this pull request May 14, 2026
Merged
@wvpm
wvpm force-pushed the minimise_fp_header branch 5 times, most recently from 5f83fad to b3480ce Compare May 16, 2026 13:33
Spartan322
Spartan322 reviewed May 16, 2026
View reviewed changes
Comment thread src/openvic-simulation/types/fixed_point/String.hpp Outdated
@wvpm
wvpm force-pushed the minimise_fp_header branch from e636961 to 2674f03 Compare May 16, 2026 13:45
@wvpm
wvpm disabled auto-merge May 17, 2026 11:04
@wvpm
wvpm force-pushed the minimise_fp_header branch from 2674f03 to f3a283b Compare May 17, 2026 11:20
@wvpm
wvpm enabled auto-merge May 17, 2026 11:20
@wvpm
wvpm merged commit 9c93b69 into master May 17, 2026
16 checks passed
@Spartan322
Spartan322 deleted the minimise_fp_header branch May 17, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Spartan322 Spartan322 Spartan322 approved these changes

Assignees

No one assigned

Labels

enhancement Issue that describes an improvement to the project topic:codestyle Issue that applies stylistic changes to the module, semantics and mechanics should not change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wvpm @zaaarf @Spartan322