Repository navigation
feat(sync): accept encrypted seen RSS item marks - #40
Merged
Merged
Conversation
Clients sync the RSS feed items marked as seen in a separate seenRssItems collection. The seen_rss_items capability tells them the server accepts it; older clients ignore both.
1 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenTubeX now marks RSS feed items as new and lets you mark them as seen or unseen, but those marks only stay on the device where you set them. To sync them, clients need a place to store them on the server.
The server now accepts an encrypted
seenRssItemscollection with a 16 MiB limit, the same as seen-video and seen-post marks, and advertisesseen_rss_items: 1in/health. Like other collections, it is opaque ciphertext and counts toward the account's 128 MiB total. Clients only sync the collection when the capability is present, so they keep working against older servers.Older clients are unaffected. They ignore the new capability and only download the collections they know, as with
externalMediaPositionsin #39.Proof: the collection limit and
/healthtests now cover the new collection and capability, and all 13 encrypted sync and health tests pass with the environment CI uses.cargo fmt --checkandcargo clippy --all-targetsare clean. The 6 tests that fetch real YouTube data fail locally without network access, with or without this change. A Docker build of this server advertisedseen_rss_items: 1and passede2e/tests/network/sync-server.spec.mjswith the client from the companion pull request, OpenTubeX/OpenTubeX#2659, (11 passed, 1 skipped), which now expects theseenRssItemsupload.Reviewed with sol-loop: 2 rounds with GPT-6.1 Sol on high.
Sol verdict: approved
Made by Claude Opus 5.5 in Claude Code (T3 Code).