Add: Missing features to random switch.#433
Open
Rito13 wants to merge 1 commit into
Open
Conversation
Contributor
|
Not sure, but 0x0D being empty might be wrong. |
Rito13
force-pushed
the
missing_random_features
branch
from
12db253 to
8bb0fad
Compare
Contributor
Author
|
Based on newgrf_airport.cpp L198 and newgrf_spritegroup.cpp L268 I think that NFO specs are correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When road stops and badges were added the data for random action 2 was not.
Add TILE and SELF for road stops matching behaviour in stations. However road stops have 8 bits in TILE when stations have only 4 (based on https://newgrf-specs.tt-wiki.net/wiki/RandomAction2#Triggers)
Add empty dictionary for badges to generate pretty errors instead of internal ones.