Change: Use explicit (Var)Action2 results for "callback failed" and "calculated result".#432
Open
Rito13 wants to merge 1 commit into
Open
Change: Use explicit (Var)Action2 results for "callback failed" and "calculated result".#432Rito13 wants to merge 1 commit into
Rito13 wants to merge 1 commit into
Conversation
…calculated result".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
OpenTTD/OpenTTD#14149 has been merged and released in OTTD 15.0.
Problem
Description
Instead of generating special action2 for failure result and then returning its id return 0x7FFF.
Instead of generating special action2 for querying the result from most recent VarAction2 and then returning its id return 0x7FFE
Remove related methods used for generating failure action2.
Limitations
Will make NewGRFs that use
CB_FAILEDor "calculated result" incompatible with OpenTTD older than 15.0 and TTDP.