Fix b86d930: incorrect sprite ID limit, and reuse old IDs when limit is reached#431
Merged
Conversation
glx22
changed the title
Contributor
|
Works for me. Resolves the failure cases that Iron Horse exposed. |
PeterN
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#309 replaced a global limit of
0xFFsprites per action1 block with a max id (0x3FFFor0xFFFFdepending on feature) stored in each collection. Andnmlccrashes once the limit is reached.Actually all features should have
0x3FFFas max id.And crashing when limit is reached is not nice, it's better to start reusing old IDs.