Skip to content

Fix demand-loaded building artwork ownership - #5

Open
Krisztiaan wants to merge 2 commits into
OpenTS-Developers:mainfrom
Krisztiaan:fix/demand-loaded-building-art-ownership
Open

Fix demand-loaded building artwork ownership#5
Krisztiaan wants to merge 2 commits into
OpenTS-Developers:mainfrom
Krisztiaan:fix/demand-loaded-building-art-ownership

Conversation

@Krisztiaan

@Krisztiaan Krisztiaan commented Aug 27, 2026

Copy link
Copy Markdown

Summary

Fix demand-loaded building artwork ownership and deallocation, preventing heap corruption in mods such as TFADW.

Behavior and compatibility

Bug fix for DemandLoad, DemandLoadBuildup, and FreeBuildup. No format, save, replay, networking, determinism, COM, or ABI changes.

Validation

  • VS2022 Win32 Debug and Release builds and tests passed.
  • Exact Release artifact tested under Wine with TFADW 1.02 and UnitCount=1.
  • Skirmish loaded, demand-loaded artwork initialized, and gameplay began without the original crash.
  • Native Windows runtime not tested.

Documentation

Updated the affected key documentation, MIX ownership guidance, and change record.

Checklist

  • The change is focused; unrelated mechanical cleanup is separate
  • Compatibility effects and any migration are explicit
  • Validation distinguishes what passed, failed, and was not run
  • No prohibited assets, binaries, SDKs, credentials, or generated output are included

@Krisztiaan
Krisztiaan marked this pull request as ready for review August 28, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant