Skip to content

Fix fog-of-war edge redraw crashes - #4

Open
Krisztiaan wants to merge 2 commits into
OpenTS-Developers:mainfrom
Krisztiaan:fix/fogged-object-edge-redraw
Open

Fix fog-of-war edge redraw crashes#4
Krisztiaan wants to merge 2 commits into
OpenTS-Developers:mainfrom
Krisztiaan:fix/fogged-object-edge-redraw

Conversation

@Krisztiaan

Copy link
Copy Markdown

Summary

  • Clip fogged-object redraws to the tactical view.
  • Use the owning house’s color converter for fogged buildings instead of treating a map cell as a converter.

Prevents out-of-bounds rendering and CellClass memory corruption during fog-of-war redraws.

Behavior and compatibility

Bug fix; intended rendering behavior is preserved.

No other changes.

Validation

  • VS2022 Win32 Debug and Release builds passed.
  • Tests passed in both configurations.
  • python manual/tools/manage.py check
  • Release tested under Wine:
    Firestorm skirmish, G_CANYON.MAP, Fog of War enabled, AI present, unit movement and aggressive edge panning; no crash.
  • Native Windows runtime testing was not performed yet!!

Documentation

manual/changes/fogged-object-edge-redraw.md.

Checklist

  • The change is focused; unrelated mechanical cleanup is separate
  • Compatibility effects and any migration are explicit
  • Validation distinguishes what passed, failed, and was not run
  • No prohibited assets, binaries, SDKs, credentials, or generated output are included

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant