Skip to content

Update Gesture system infra#903

Merged
Kyle-Ye merged 21 commits into
mainfrom
feature/tap_gestures
Jun 9, 2026
Merged

Update Gesture system infra#903
Kyle-Ye merged 21 commits into
mainfrom
feature/tap_gestures

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Jun 9, 2026

Copy link
Copy Markdown
Member

No description provided.

@augmentcode

augmentcode Bot commented Jun 9, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR updates OpenSwiftUI’s gesture infrastructure and adds new formatting support for time-driven text.

Changes:

  • Adds an optional build flag to link the private Gestures framework (OPENSWIFTUI_LINK_GESTURES) and wires it into all relevant targets.
  • Extends package platform selection to handle a 2025 release target (e.g. "26.0" platform versions) when gesture/private-framework linking is enabled.
  • Introduces a suite of new gesture building blocks: callback gestures (onChanged/onEnded), event listening/filtering, coordinate-space conversion, delayed/duration/distance gestures, repeat support, category propagation, required tap count, and gesture state container support.
  • Adds truePreference helpers for both View and Gesture to write boolean preferences, enabling features like cancellable().
  • Guards CoreUI/Symbol animation code behind OPENSWIFTUI_LINK_COREUI to support builds that don’t link CoreUI.
  • Implements large portions of Text discrete time formatting, including TimeDataSource and live-updating Text initializers using DiscreteFormatStyle.

Technical Notes: Gesture behavior is driven via AttributeGraph rules and preference propagation; the new time-format Text path resolves values based on the environment’s current date and locale.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread Sources/OpenSwiftUICore/View/Text/Text/Text+DiscreteFormatStyle.swift Outdated
@Kyle-Ye Kyle-Ye force-pushed the feature/tap_gestures branch from abc956b to ab2467a Compare June 9, 2026 16:16
@github-actions github-actions Bot added area: event-gesture Events, gestures, tracing, or interaction plumbing. type: feature New API, behavior, platform support, or user-facing capability. labels Jun 9, 2026
@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 804 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.28%. Comparing base (e10497d) to head (ab2467a).

Files with missing lines Patch % Lines
...enSwiftUICore/Event/Gesture/CallbacksGesture.swift 0.00% 137 Missing ⚠️
.../OpenSwiftUICore/Event/Gesture/EventListener.swift 0.00% 128 Missing ⚠️
...es/OpenSwiftUICore/Event/Gesture/Map2Gesture.swift 0.00% 87 Missing ⚠️
...penSwiftUICore/Event/Gesture/DurationGesture.swift 0.00% 69 Missing ⚠️
.../OpenSwiftUICore/Event/Gesture/RepeatGesture.swift 0.00% 57 Missing ⚠️
...OpenSwiftUICore/Event/Gesture/DelayedGesture.swift 0.00% 51 Missing ⚠️
...es/OpenSwiftUICore/Event/Gesture/EventFilter.swift 0.00% 49 Missing ⚠️
...penSwiftUICore/Event/Gesture/DistanceGesture.swift 0.00% 38 Missing ⚠️
...penSwiftUICore/Event/Gesture/CategoryGesture.swift 0.00% 33 Missing ⚠️
...ces/OpenSwiftUICore/Event/Gesture/MapGesture.swift 0.00% 30 Missing ⚠️
... and 9 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #903       +/-   ##
===========================================
+ Coverage   14.22%   26.28%   +12.05%     
===========================================
  Files         654      710       +56     
  Lines       42646    49705     +7059     
===========================================
+ Hits         6065    13063     +6998     
- Misses      36581    36642       +61     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye merged commit cf9a0d4 into main Jun 9, 2026
8 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/tap_gestures branch June 9, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: event-gesture Events, gestures, tracing, or interaction plumbing. type: feature New API, behavior, platform support, or user-facing capability.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant