-
Notifications
You must be signed in to change notification settings - Fork 4
Feature: standard mui dialog #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
bf2a5ac
v5.0.50-beta.0
santipalenque 16b2f86
chore: create custom dialog shell and reuse it in all dialogs
santipalenque f5cfcd6
chore: move actions to custom dialog
santipalenque 7f1e258
v5.0.50-beta.1
santipalenque af3ee7f
chore: update AlertModal, NotesModal, ItemSettingsModal, UploadDialog…
santipalenque f0a113d
chore: pr review
santipalenque 44db4e6
chore: pr review
santipalenque File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,153 @@ | ||
| /** | ||
| * Copyright 2026 OpenStack Foundation | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * */ | ||
|
|
||
| import React, { useEffect, useRef, useState } from "react"; | ||
| import PropTypes from "prop-types"; | ||
| import { | ||
| Button, | ||
| CircularProgress, | ||
| Dialog, | ||
| DialogActions, | ||
| DialogContent, | ||
| DialogTitle, | ||
| Divider, | ||
| IconButton | ||
| } from "@mui/material"; | ||
| import CloseIcon from "@mui/icons-material/Close"; | ||
|
|
||
| const CustomDialog = ({ | ||
| title, | ||
| open, | ||
| onClose, | ||
| maxWidth, | ||
| fullWidth, | ||
| primaryAction, | ||
| secondaryAction, | ||
| children | ||
| }) => { | ||
| const [isSubmitting, setIsSubmitting] = useState(false); | ||
|
santipalenque marked this conversation as resolved.
|
||
| // the only purpose of this is to avoid having a console log when modal is closed and setIsSubmitting is called | ||
| const mountedRef = useRef(true); | ||
|
|
||
| useEffect(() => { | ||
| mountedRef.current = true; | ||
| return () => { | ||
| mountedRef.current = false; | ||
|
santipalenque marked this conversation as resolved.
|
||
| }; | ||
| }, []); | ||
|
|
||
| const runAction = (action) => { | ||
| if (isSubmitting) return; | ||
|
|
||
| const result = action.onClick(); | ||
|
|
||
| // if action is async then guard double click | ||
| if (result && typeof result.then === "function") { | ||
| setIsSubmitting(true); | ||
| Promise.resolve(result) | ||
| .catch(() => {}) | ||
| .finally(() => { | ||
| if (mountedRef.current) setIsSubmitting(false); | ||
| }); | ||
| } | ||
| }; | ||
|
|
||
| const handlePrimaryClick = () => runAction(primaryAction); | ||
| const handleSecondaryClick = () => runAction(secondaryAction); | ||
|
|
||
| const handleClose = () => { | ||
| if (isSubmitting) return; | ||
| onClose(); | ||
| }; | ||
|
|
||
| return ( | ||
| <Dialog | ||
| open={open} | ||
| onClose={handleClose} | ||
| maxWidth={maxWidth} | ||
| fullWidth={fullWidth} | ||
| disableEscapeKeyDown={isSubmitting} | ||
| > | ||
| <DialogTitle>{title}</DialogTitle> | ||
| <IconButton | ||
| aria-label="close" | ||
| onClick={handleClose} | ||
| disabled={isSubmitting} | ||
| size="small" | ||
| sx={(theme) => ({ | ||
| position: "absolute", | ||
| right: 12, | ||
| top: 12, | ||
| color: theme.palette.grey[500] | ||
| })} | ||
| > | ||
| <CloseIcon fontSize="large" /> | ||
| </IconButton> | ||
| <Divider /> | ||
| <DialogContent>{children}</DialogContent> | ||
|
santipalenque marked this conversation as resolved.
|
||
| {(primaryAction || secondaryAction) && ( | ||
| <DialogActions> | ||
| {secondaryAction && ( | ||
|
santipalenque marked this conversation as resolved.
|
||
| <Button | ||
| variant="outlined" | ||
| onClick={handleSecondaryClick} | ||
| disabled={isSubmitting || secondaryAction.disabled} | ||
| > | ||
| {secondaryAction.label} | ||
| </Button> | ||
| )} | ||
| {primaryAction && ( | ||
| <Button | ||
| variant="contained" | ||
| onClick={handlePrimaryClick} | ||
| disabled={isSubmitting || primaryAction.disabled} | ||
| startIcon={ | ||
| isSubmitting ? ( | ||
| <CircularProgress size={16} color="inherit" /> | ||
| ) : null | ||
| } | ||
| > | ||
| {primaryAction.label} | ||
| </Button> | ||
| )} | ||
| </DialogActions> | ||
| )} | ||
| </Dialog> | ||
| ); | ||
| }; | ||
|
|
||
| const actionPropType = PropTypes.shape({ | ||
| label: PropTypes.node.isRequired, | ||
| onClick: PropTypes.func.isRequired, | ||
| disabled: PropTypes.bool | ||
| }); | ||
|
|
||
| CustomDialog.propTypes = { | ||
| title: PropTypes.node.isRequired, | ||
| open: PropTypes.bool.isRequired, | ||
| onClose: PropTypes.func.isRequired, | ||
| maxWidth: PropTypes.oneOf(["xs", "sm", "md", "lg", "xl", false]), | ||
| fullWidth: PropTypes.bool, | ||
| primaryAction: actionPropType, | ||
| secondaryAction: actionPropType, | ||
| children: PropTypes.node.isRequired | ||
| }; | ||
|
|
||
| CustomDialog.defaultProps = { | ||
| maxWidth: "sm", | ||
| fullWidth: true, | ||
| primaryAction: null, | ||
| secondaryAction: null | ||
| }; | ||
|
|
||
| export default CustomDialog; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.