Backport: Add header guards and clean up Button self-qualification (aeos)#153
Merged
livingkurt merged 1 commit intoaeosfrom Mar 28, 2026
Merged
Backport: Add header guards and clean up Button self-qualification (aeos)#153livingkurt merged 1 commit intoaeosfrom
livingkurt merged 1 commit intoaeosfrom
Conversation
Port of master PR #152 cleanup changes to aeos branch: - Add proper #ifndef/#define header guards to Button.h, Helios.h, ColorConstants.h, and Random.h (replacing #pragma once where used) - Rename Colortypes.h guard from COLOR_H to COLORTYPES_H - Remove Helios::wakeup() from ISR (not used on embedded) - Remove unnecessary Button:: self-qualification on static method calls within Button.cpp (holdPressing, processPreInput, processPostInput) - Extract repeated Time::getCurtime() calls into const local variable in Button::update() - Move Led::setBrightness() out of inline into Led.cpp - Remove commented-out include from Pattern.cpp - Remove unused Led.h include from TimeControl.cpp - Update TimeControl.h comments for clarity Made-with: Cursor
Unreal-Dan
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port of master PR #152 cleanup changes to the
aeosbranch. These are the same underlying API files so the cleanups apply identically.#ifndef/#defineheader guards toButton.h,Helios.h,ColorConstants.h, andRandom.h(replacing#pragma oncewhere used)Colortypes.hguard fromCOLOR_H→COLORTYPES_Hto match the filenameHelios::wakeup()from the embedded ISR (not used on embedded, was never needed)Button::self-qualification on static method calls withinButton.cpp(holdPressing,processPreInput,processPostInput)Time::getCurtime()calls into aconstlocal variable inButton::update()Led::setBrightness()out of inline in the header intoLed.cppPattern.cppLed.hinclude fromTimeControl.cppTimeControl.hcomments for clarity (remove stale singleton comment, improve API docs)Test plan
Made with Cursor