[DO NOT MERGE] kurt/helios-RAII-wasm by livingkurt · Pull Request #151 · OpenSourceLightshows/HeliosEngine

livingkurt · 2026-02-20T17:26:34Z

This PR adds the HeliosInstance class to enable multiple independent WASM engine instances on the same page.

Changes

HeliosInstance.h/cpp: New class with per-instance pattern/colorset/state (not static/global)
HeliosLib.cpp: WASM bindings for HeliosInstance class
Makefile: Include new source files

Why

The current Helios class uses all static members, making it impossible to have multiple independent mode previews on the same page (like a grid of mode cards). Each preview would share the same pattern/colorset state.

Usage

const lib = await HeliosLib();
const instance1 = new lib.HeliosInstance();
const instance2 = new lib.HeliosInstance();
instance1.init();
instance2.init();
// Each instance has independent pattern/colorset/tick

This enables the Glow-LEDs mode grid to show live previews for all modes simultaneously.

…ine instances"" This reverts commit b8b7065.

- Remove Helios.h include from HeliosInstance.h (circular include) - Fix getCurColor() to not be const (accesses static Led) - Remove cur_pattern from WASM bindings (caused embind template errors) - Keep only needed methods: init, tick, getCurColor, setColorset, setArgs, setMode

- Add static create() method to HeliosInstance - Export createHeliosInstance() function from WASM - Update JS to use factory function instead of constructor

- Include TimeControl.h to manage timing for patterns. - Call Time::tickClock() in the tick() method to ensure pattern timers function correctly.

…ts across Helios components

Convert Helios controller and core services (pattern runtime, storage, LED, time, and button) to instance-owned state, preserve ISR bridge compatibility, and isolate WASM bindings/build to instance-only APIs.

Introduce HeliosCallbacks and wire button, LED, time, and storage hookpoints through Helios/HeliosLib, with WASM-exposed callback registration APIs for event-driven host integration.

Allow NUM_COLOR_SLOTS override from config and set a safe WASM slot cap so randomizer can vary from 1..N without being hard-limited to 6.

…ntime API. This updates Helios core ownership wiring to use Helios-scoped dependencies, removes legacy static runtime bridges, and consolidates WASM preview/randomizer behavior onto HeliosLib while preserving existing frontend behavior.

This removes remaining non-conforming helper/globals and inheritance layers, deletes obsolete HeliosInstance/HeliosPattern* files, and keeps engine/runtime access consistently instance-based through Helios references.

…te LED color setting to only occur when the color is marked as dirty, improving efficiency. Initialize and reset color dirty state in Pattern class.

Unreal-Dan · 2026-02-24T16:50:56Z

 #ifdef HELIOS_EMBEDDED
 #ifdef HELIOS_ARDUINO
-  return digitalRead(3) == HIGH;
+  defaultState = digitalRead(3) == HIGH;


This is changing the code, dont change the code.

Do not create new variables or logic.

This should work exactly the same as it did before.

Adding the ifdef to call the callback a few lines down is correct, but adding defaultState is not, get rid of it.

Unreal-Dan · 2026-02-24T16:52:07Z

-  return m_pinState;
+  defaultState = m_pinState;
 #endif
+  return m_helios.callbacks().checkPinHook(BUTTON_PIN, defaultState);


This should be inside a ifdef helios_lib it only builds on desktop.

The whole callbacks thing should all be inside ifdef helios lib. Callbacks dont exist if you built this branch for embedded

Unreal-Dan · 2026-02-24T17:08:44Z

 #include <queue>
 #endif

+class Time;


Forward decls should not be necessary, delete.

If they are necessary its because something is done wrong.

Shouldn't have references to time or whatever here in the header, and where they are used in the cpp file the appropriate header would just be included.

So ya delete these forward decls

Unreal-Dan · 2026-02-24T17:16:21Z

-// The number of slots in a colorset
+// The number of slots in a colorset.
+// Firmware default remains 6, but WASM can override via compiler define.
+#ifndef NUM_COLOR_SLOTS


Unreal-Dan · 2026-02-24T17:17:46Z


 #include "Led.h"

-#include "TimeControl.h"


Your still using m_helios.time()

You still should include this, the only reason it works without this include is because another header indirectly included it.

Restore this, unnecessary deletion

…d duration calculations. Introduce external Helios reference in ISR for wakeup functionality. Update Button header guard for consistency.

…M build - Add fade_dur param to PatternArgs (Pattern.h/cpp) - Add isFade() method and tickFade() logic to Pattern - Add PATTERN_FADE, PATTERN_MORPH_FADE, PATTERN_GLITCH_FADE to Patterns.h/cpp - Update HeliosLib WASM bindings for new fade_dur param and pattern IDs - Fix pre-existing WASM build errors: Pattern pointer initialization with Helios ref, checkPinHook signature mismatch, missing restart/tick/getCurColor Made-with: Cursor

tickClock() busy-waits up to 1ms per tick to enforce TICKRATE=1000. When multiple WASM engines run in parallel (fingerroll/multi-light preview), this blocks the browser main thread causing severe lag. JS rAF controls timing for WASM, so the timestep serves no purpose and must be disabled. Made-with: Cursor

Backport cleanup from master (#152): replace #pragma once in Button.h and add missing include guard to Helios.h with standard #ifndef guards. This reduces the diff against master for the RAII PR review. Made-with: Cursor

Unreal-Dan · 2026-03-27T16:48:31Z

 # generic clean target
 clean:
 	@$(RM) $(DFILES) $(OBJS) $(TARGETS) $(TESTS)
+	@$(RM) ../Helios/*.o ../Helios/*.d ../Helios/*.avr.o ../Helios/*.avr.d


do we want this in main/helios/aeos?

Unreal-Dan · 2026-03-27T16:48:36Z


 clean:
 	rm -f $(OBJS) $(TARGET).elf $(TARGET).hex $(DFILES) $(TARGET).bin $(TARGET).eep $(TARGET).lst $(TARGET).map
+	rm -f ../Helios/*.o ../Helios/*.d ../Helios/*.avr.o ../Helios/*.avr.d


same here, do we want this in main/helios/aeos?

Unreal-Dan · 2026-03-27T16:55:05Z


 ifdef WASM
 DEFINES += -D WASM
+DEFINES += -D NUM_COLOR_SLOTS=80


what the heck is NUM_COLOR_SLOTS for O.o

Unreal-Dan · 2026-03-27T16:55:24Z

 # generic clean target
 clean:
 	@$(RM) $(DFILES) $(OBJS) $(TARGETS) $(TESTS) HeliosLib.js HeliosLib.wasm
+	@$(RM) ../Helios/*.o ../Helios/*.d ../Helios/*.avr.o ../Helios/*.avr.d


same here, do we want this in main?

- Fix Pattern::crc32() to hash only m_args and m_colorset directly, skipping the m_helios reference (a pointer with non-deterministic address that made the randomizer seed change each run) - Restore helios.wakeup() in HELIOS_EMBEDDED ISR(PCINT0_vect) using the global Helios instance per Daniel's review feedback - Re-record 22 integration tests whose golden output changed due to the new PATTERN_FADE/MORPH_FADE/GLITCH_FADE pattern IDs shifting the PATTERN_COUNT used by the randomizer Made-with: Cursor

- Add comment to HeliosLib/Makefile explaining NUM_COLOR_SLOTS=80: overrides the embedded default of 6 so the WASM web editor supports up to 80 colors per mode (no flash constraints in browser) - Remove stale comment "this was used before..." from HeliosLib/Makefile (LDFLAGS line is still needed) - Add comments to all three clean targets noting they are candidates to backport to master/aeos (intentional full-repo clean behavior) Made-with: Cursor

Made-with: Cursor

Herc added 2 commits February 20, 2026 17:26

Revert "Revert "Add HeliosInstance class for multiple independent eng…

1e7f952

…ine instances"" This reverts commit b8b7065.

livingkurt force-pushed the feature/helios-instance branch from 47e3e00 to 80f27a1 Compare February 20, 2026 17:53

Herc and others added 6 commits February 20, 2026 17:57

Fix: add Led.h include to HeliosInstance.cpp

89b9d83

Fix: use factory function instead of constructor for HeliosInstance

a8b0dcb

- Add static create() method to HeliosInstance - Export createHeliosInstance() function from WASM - Update JS to use factory function instead of constructor

Update WASM binding for createHeliosInstance to allow raw pointers

98626c9

Add TimeControl integration in HeliosInstance

8a8e614

- Include TimeControl.h to manage timing for patterns. - Call Time::tickClock() in the tick() method to ensure pattern timers function correctly.

Update HeliosEngine

b93ce8f

Update HeliosEngine

a94ba4e

livingkurt changed the title ~~Add HeliosInstance class for multiple independent engine instances~~ kurt/helos-instance Feb 20, 2026

livingkurt added 6 commits February 20, 2026 22:20

Enhance clean targets in Makefiles to remove additional build artifac…

eef9158

…ts across Helios components

Update HeliosEngine

a48c32c

Complete full RAII runtime migration in Helios core.

988a720

Convert Helios controller and core services (pattern runtime, storage, LED, time, and button) to instance-owned state, preserve ISR bridge compatibility, and isolate WASM bindings/build to instance-only APIs.

Add full HeliosLib hookpoint callback architecture.

fc8a195

Introduce HeliosCallbacks and wire button, LED, time, and storage hookpoints through Helios/HeliosLib, with WASM-exposed callback registration APIs for event-driven host integration.

Update HeliosEngine

555d324

Restore variable seeded randomizer count for WASM colorsets.

ff12bdf

Allow NUM_COLOR_SLOTS override from config and set a safe WASM slot cap so randomizer can vary from 1..N without being hard-limited to 6.

livingkurt changed the title ~~kurt/helos-instance~~ [DO NOT MERGE] kurt/helios-RAII-wasm Feb 22, 2026

livingkurt added 3 commits February 22, 2026 16:09

Apply strict RAII conformance pass for HeliosLib branch.

fc7c5fb

This removes remaining non-conforming helper/globals and inheritance layers, deletes obsolete HeliosInstance/HeliosPattern* files, and keeps engine/runtime access consistently instance-based through Helios references.

Refactor color handling in Helios to use a dirty flag mechanism. Upda…

54cebfe

…te LED color setting to only occur when the color is marked as dirty, improving efficiency. Initialize and reset color dirty state in Pattern class.

Unreal-Dan reviewed Feb 24, 2026

View reviewed changes

livingkurt mentioned this pull request Feb 27, 2026

Backport: Add header guards and clean up Button self-qualification #152

Merged

2 tasks

livingkurt and others added 2 commits February 27, 2026 21:34

Refactor Button class to streamline pin state checking and update hol…

d028781

…d duration calculations. Introduce external Helios reference in ISR for wakeup functionality. Update Button header guard for consistency.

small changes to start

1836cf5

Unreal-Dan force-pushed the feature/helios-instance branch from 893f278 to 1836cf5 Compare March 3, 2026 08:57

Unreal-Dan added 5 commits March 4, 2026 09:55

small code restore to led

09aead0

remove unnecessary forward declaration

e253ebd

restored pattern code

2a9e3a0

fixed up storage and callback for storage

89c9f5c

fixed up timecontrol

0235cc6

Unreal-Dan and others added 11 commits March 4, 2026 23:40

small adjustments

30b71b2

fixed up timer

c61ee54

some more cleanup

b7ef946

fixed up cli tool

aafc277

more fixes

5bb59d6

small fixes

fac11ac

proper header guard

d5efc2d

Add proper header guards to Button.h and Helios.h

0da3861

Backport cleanup from master (#152): replace #pragma once in Button.h and add missing include guard to Helios.h with standard #ifndef guards. This reduces the diff against master for the RAII PR review. Made-with: Cursor

Merge branch 'master' into feature/helios-instance

4f5aaf2

Unreal-Dan reviewed Mar 27, 2026

View reviewed changes

livingkurt added 3 commits March 28, 2026 16:58

Reduce NUM_COLOR_SLOTS from 80 to 16 for WASM build

e9789ad

Made-with: Cursor

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DO NOT MERGE] kurt/helios-RAII-wasm#151

[DO NOT MERGE] kurt/helios-RAII-wasm#151
livingkurt wants to merge 38 commits intomasterfrom
feature/helios-instance

livingkurt commented Feb 20, 2026

Uh oh!

Uh oh!

Unreal-Dan Feb 24, 2026

Uh oh!

Unreal-Dan Feb 24, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Unreal-Dan Feb 24, 2026

Uh oh!

Uh oh!

Unreal-Dan Feb 24, 2026

Uh oh!

Unreal-Dan Feb 24, 2026

Uh oh!

Unreal-Dan Mar 27, 2026

Uh oh!

Unreal-Dan Mar 27, 2026

Uh oh!

Unreal-Dan Mar 27, 2026

Uh oh!

Unreal-Dan Mar 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

livingkurt commented Feb 20, 2026

Changes

Why

Usage

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants