AudioLocation.h: add missing <cstdint> include - #1086
Open
Chzrz89 wants to merge 1 commit into
Open
Conversation
The struct uses int64_t but relied on transitive includes for it.
GCC 16 no longer provides int64_t transitively, causing the struct
definition to fail parsing ('int64_t' does not name a type) and
cascading 'has no member frame' errors in Clip.cpp.
Explicitly include <cstdint> so the header is self-contained.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One-line fix: add
#include <cstdint>tosrc/AudioLocation.h.The struct uses
int64_tbut relied on it arriving via transitive includes. GCC 16 no longer providesint64_ttransitively, so the struct definition fails to parse:which cascades into misleading
struct openshot::AudioLocation has no member named frameerrors at every use site inClip.cpp.Making the header self-contained fixes the build with no behavior change.
Testing