Efficiency improvements to coverage plans with large ring-sizes (re-s… - #39
Closed
martinsumner wants to merge 1 commit into
Closed
Efficiency improvements to coverage plans with large ring-sizes (re-s…#39martinsumner wants to merge 1 commit into
martinsumner wants to merge 1 commit into
Conversation
#36) * Efficiency improvements to coverage plans with large ring-sizes (re-submit) Remove unnecessary sort, once per loop. For each split mark, cache the calculation of the vnode list as a persistent_term. These will never change, and there will be a need for RingSize terms per node - and is bounded to that upper limit. Second attempt at commit, after making inadvertent commit. * Add specs and comments to clarify code * Rename ordered_vnodes as shuffled_positions * Update src/riak_core_coverage_plan.erl Co-authored-by: Thomas Arts <thomas.arts@quviq.com> --------- Co-authored-by: Thomas Arts <thomas.arts@quviq.com>
Contributor
Author
|
Reviewed in #36 |
Contributor
Author
|
Replaced by #45 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…… (#36)
Remove unnecessary sort, once per loop.
For each split mark, cache the calculation of the vnode list as a persistent_term. These will never change, and there will be a need for RingSize terms per node - and is bounded to that upper limit.
Second attempt at commit, after making inadvertent commit.
Add specs and comments to clarify code
Rename ordered_vnodes as shuffled_positions
Update src/riak_core_coverage_plan.erl