Skip to content

run code generation tests on net10#588

Merged
Daniel-Svensson merged 2 commits into
OpenRIAServices:mainfrom
Daniel-Svensson:net10_codegen
Jun 10, 2026
Merged

run code generation tests on net10#588
Daniel-Svensson merged 2 commits into
OpenRIAServices:mainfrom
Daniel-Svensson:net10_codegen

Conversation

@Daniel-Svensson

@Daniel-Svensson Daniel-Svensson commented Jun 8, 2026

Copy link
Copy Markdown
Member

This fix makes the tests run and pass on standard VS 2026 install where dotnet 8 SDK is not installed

Summary by CodeRabbit

  • Chores
    • Added .NET 10.0 as a target framework across multiple projects to extend SDK and test support.
    • Updated client-generation tooling to also look for codegen outputs for the newer framework, improving compatibility when generating client proxies.

@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 6a954889-ac72-4eb5-b5a1-9b7a40e3925e

📥 Commits

Reviewing files that changed from the base of the PR and between 6a8931d and c5ae0bc.

📒 Files selected for processing (1)
  • src/OpenRiaServices.Tools/Framework/CreateOpenRiaClientFilesTask.cs

📝 Walkthrough

Walkthrough

Seven changes: several project files update their TargetFrameworks to add or replace net10.0, and the tools launcher adds a net10.0 fallback when locating the codegen DLL before failing.

Changes

.NET 10.0 Multi-targeting and Tooling

Layer / File(s) Summary
SDK project multi-targeting expansion
src/OpenRiaServices.Client.Web/Framework/OpenRiaServices.Client.Web.csproj
OpenRiaServices.Client.Web expands its TargetFrameworks to include net10.0 alongside existing net472 and net8.0.
Test and sample projects target migration
src/OpenRiaServices.Tools.TextTemplate/Test/OpenRiaServices.Tools.TextTemplate.Test.csproj, src/OpenRiaServices.Tools/Test/ClientClassLib/ClientClassLib.csproj, src/OpenRiaServices.Tools/Test/ClientClassLib2/ClientClassLib2.csproj, src/OpenRiaServices.Tools/Test/OpenRiaServices.Tools.Test.csproj, src/OpenRiaServices.Tools/Test/ServerClassLib/ServerClassLib.csproj
Test and sample class library projects replace net8.0 with net10.0 while retaining net472.
Codegen launcher net10.0 fallback
src/OpenRiaServices.Tools/Framework/CreateOpenRiaClientFilesTask.cs
Out-of-process codegen launcher first checks net8.0/OpenRiaServices.Tools.CodeGenTask.dll, then recomputes the path to net10.0 and uses that before throwing FileNotFoundException if still missing.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 I hopped from eight into ten's bright light,
Project files updated, targets set right.
A launcher sniffed paths, found a new view,
If net8 was gone, net10 came through.
Builds and tests hum — a small spring delight.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'run code generation tests on net10' accurately describes the main objective of the changeset: updating multiple test projects and the code generation task to support .NET 10 framework targeting.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Comment thread src/OpenRiaServices.Tools/Framework/CreateOpenRiaClientFilesTask.cs Dismissed
@sonarqubecloud

sonarqubecloud Bot commented Jun 8, 2026

Copy link
Copy Markdown

@Daniel-Svensson Daniel-Svensson enabled auto-merge (squash) June 9, 2026 16:03
@Daniel-Svensson Daniel-Svensson merged commit 585cb6c into OpenRIAServices:main Jun 10, 2026
7 checks passed
@Daniel-Svensson Daniel-Svensson deleted the net10_codegen branch June 10, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants