Skip to content

Updated the alignment check method to include target_annotation_id as… #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tentse wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Updated the alignment check method to include target_annotation_id as… #440

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d51aea
Updated the alignment check method to include target_annotation_id as…
tentse Oct 29, 2025
a8b1ce9
Refined alignment check logic in AlignedPechaJsonSerializer to ensure…
tentse Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/openpecha/pecha/serializers/json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ def serialize_aligned_pechas_transformed_annotations(self):

target_annotation_id, source_annotation_id = self.get_aligned_to_annotation_id(self.source_annotations)

is_target_annnotation_is_alignement = self._check_if_target_annotation_is_alignment_(self.target_annotations)
is_target_annnotation_is_alignement = self._check_if_target_annotation_is_alignment_(self.target_annotations, target_annotation_id)

target_alignment_annotation = None
if is_target_annnotation_is_alignement:
Expand Down Expand Up @@ -350,8 +350,8 @@ def _get_target_segmentation_annotation_id_(self, target_annotations: list[dict]
raise ValueError("No segmentation annotation found")


def _check_if_target_annotation_is_alignment_(self, target_annotations: list[dict]) -> bool:
def _check_if_target_annotation_is_alignment_(self, target_annotations: list[dict], target_annotation_id: str) -> bool:
for target_annotation in target_annotations:
if (target_annotation['type'] == 'alignment'):
if (target_annotation['type'] == 'alignment' and target_annotation['id'] == target_annotation_id):
return True
return False