Skip to content

Fix app crash#14

Merged
yogeshbhagatcode merged 3 commits into
sherab-devfrom
fix-app-crash
Nov 4, 2025
Merged

Fix app crash#14
yogeshbhagatcode merged 3 commits into
sherab-devfrom
fix-app-crash

Conversation

@yogeshbhagatcode

@yogeshbhagatcode yogeshbhagatcode commented Nov 4, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@yogeshbhagatcode yogeshbhagatcode merged commit 11c2444 into sherab-dev Nov 4, 2025
1 of 4 checks passed
github-advanced-security[bot]
github-advanced-security AI found potential problems Nov 4, 2025
View reviewed changes
Comment thread course/src/main/java/org/openedx/course/presentation/unit/video/YoutubeVideoUnitFragment.kt
savedInstanceState?.let {
isUsingWebViewFallback = it.getBoolean(KEY_USING_WEBVIEW_FALLBACK, false)
webViewLastPlaybackPosition = it.getFloat(KEY_WEBVIEW_PLAYBACK_POSITION, 0f)
android.util.Log.d("YoutubeVideoUnit", "Restored state - isUsingWebViewFallback: $isUsingWebViewFallback, playback position: $webViewLastPlaybackPosition sec")

Check warning

Code scanning / detekt

Reports lines with exceeded length Warning

Exceeded max line length (120)
Comment thread course/src/main/java/org/openedx/course/presentation/unit/video/YoutubeVideoUnitFragment.kt
savedInstanceState?.let {
isUsingWebViewFallback = it.getBoolean(KEY_USING_WEBVIEW_FALLBACK, false)
webViewLastPlaybackPosition = it.getFloat(KEY_WEBVIEW_PLAYBACK_POSITION, 0f)
android.util.Log.d("YoutubeVideoUnit", "Restored state - isUsingWebViewFallback: $isUsingWebViewFallback, playback position: $webViewLastPlaybackPosition sec")

Check warning

Code scanning / detekt

Line detected, which is longer than the defined maximum line length in the code style. Warning

Line detected, which is longer than the defined maximum line length in the code style.
Comment thread course/src/main/java/org/openedx/course/presentation/unit/video/YoutubeVideoUnitFragment.kt
savedInstanceState?.let {
isUsingWebViewFallback = it.getBoolean(KEY_USING_WEBVIEW_FALLBACK, false)
webViewLastPlaybackPosition = it.getFloat(KEY_WEBVIEW_PLAYBACK_POSITION, 0f)
android.util.Log.d("YoutubeVideoUnit", "Restored state - isUsingWebViewFallback: $isUsingWebViewFallback, playback position: $webViewLastPlaybackPosition sec")

Check warning

Code scanning / detekt

Reports incorrect argument list wrapping Warning

Argument should be on a separate line (unless all arguments can fit a single line)
Comment thread course/src/main/java/org/openedx/course/presentation/unit/video/YoutubeVideoUnitFragment.kt
savedInstanceState?.let {
isUsingWebViewFallback = it.getBoolean(KEY_USING_WEBVIEW_FALLBACK, false)
webViewLastPlaybackPosition = it.getFloat(KEY_WEBVIEW_PLAYBACK_POSITION, 0f)
android.util.Log.d("YoutubeVideoUnit", "Restored state - isUsingWebViewFallback: $isUsingWebViewFallback, playback position: $webViewLastPlaybackPosition sec")

Check warning

Code scanning / detekt

Reports incorrect argument list wrapping Warning

Argument should be on a separate line (unless all arguments can fit a single line)
Comment thread course/src/main/java/org/openedx/course/presentation/unit/video/YoutubeVideoUnitFragment.kt
savedInstanceState?.let {
isUsingWebViewFallback = it.getBoolean(KEY_USING_WEBVIEW_FALLBACK, false)
webViewLastPlaybackPosition = it.getFloat(KEY_WEBVIEW_PLAYBACK_POSITION, 0f)
android.util.Log.d("YoutubeVideoUnit", "Restored state - isUsingWebViewFallback: $isUsingWebViewFallback, playback position: $webViewLastPlaybackPosition sec")

Check warning

Code scanning / detekt

Reports incorrect argument list wrapping Warning

Missing newline before ")"
Comment thread course/src/main/java/org/openedx/course/presentation/unit/video/YoutubeVideoUnitFragment.kt
}

outState.putFloat(KEY_WEBVIEW_PLAYBACK_POSITION, webViewLastPlaybackPosition)
android.util.Log.d("YoutubeVideoUnit", "Saving state - isUsingWebViewFallback: $isUsingWebViewFallback, position: $webViewLastPlaybackPosition sec")

Check warning

Code scanning / detekt

Reports lines with exceeded length Warning

Exceeded max line length (120)
Comment thread course/src/main/java/org/openedx/course/presentation/unit/video/YoutubeVideoUnitFragment.kt
}

outState.putFloat(KEY_WEBVIEW_PLAYBACK_POSITION, webViewLastPlaybackPosition)
android.util.Log.d("YoutubeVideoUnit", "Saving state - isUsingWebViewFallback: $isUsingWebViewFallback, position: $webViewLastPlaybackPosition sec")

Check warning

Code scanning / detekt

Line detected, which is longer than the defined maximum line length in the code style. Warning

Line detected, which is longer than the defined maximum line length in the code style.
Comment thread course/src/main/java/org/openedx/course/presentation/unit/video/YoutubeVideoUnitFragment.kt
}

outState.putFloat(KEY_WEBVIEW_PLAYBACK_POSITION, webViewLastPlaybackPosition)
android.util.Log.d("YoutubeVideoUnit", "Saving state - isUsingWebViewFallback: $isUsingWebViewFallback, position: $webViewLastPlaybackPosition sec")

Check warning

Code scanning / detekt

Reports incorrect argument list wrapping Warning

Argument should be on a separate line (unless all arguments can fit a single line)
Comment thread course/src/main/java/org/openedx/course/presentation/unit/video/YoutubeVideoUnitFragment.kt
}

outState.putFloat(KEY_WEBVIEW_PLAYBACK_POSITION, webViewLastPlaybackPosition)
android.util.Log.d("YoutubeVideoUnit", "Saving state - isUsingWebViewFallback: $isUsingWebViewFallback, position: $webViewLastPlaybackPosition sec")

Check warning

Code scanning / detekt

Reports incorrect argument list wrapping Warning

Argument should be on a separate line (unless all arguments can fit a single line)
Comment thread course/src/main/java/org/openedx/course/presentation/unit/video/YoutubeVideoUnitFragment.kt
}

outState.putFloat(KEY_WEBVIEW_PLAYBACK_POSITION, webViewLastPlaybackPosition)
android.util.Log.d("YoutubeVideoUnit", "Saving state - isUsingWebViewFallback: $isUsingWebViewFallback, position: $webViewLastPlaybackPosition sec")

Check warning

Code scanning / detekt

Reports incorrect argument list wrapping Warning

Missing newline before ")"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yogeshbhagatcode @github-advanced-security