Feature image UI fix#11
Conversation
… for tablet screens
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| modifier = Modifier | ||
| .fillMaxWidth() | ||
| .height(90.dp) | ||
| .aspectRatio(16f / 9f) |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning
| modifier = Modifier | ||
| .fillMaxWidth() | ||
| .height(90.dp) | ||
| .aspectRatio(16f / 9f) |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning
| modifier = Modifier | ||
| .fillMaxWidth() | ||
| .height(90.dp) | ||
| .aspectRatio(16f / 9f) |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning
| modifier = Modifier | ||
| .fillMaxWidth() | ||
| .height(90.dp) | ||
| .aspectRatio(16f / 9f) |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning
| } | ||
|
|
||
| val columns = if (windowSize.width == WindowType.Compact) { | ||
| GridCells.Fixed(2) // phone |
Check warning
Code scanning / detekt
Reports multiple space usages Warning
| .width(imageWidth) | ||
| .height(105.dp) | ||
| .fillMaxWidth() | ||
| .aspectRatio(16f / 9f) // image scales with width |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning
| .fillMaxWidth() | ||
| .padding(top = 8.dp), | ||
| .padding(top = 4.dp) | ||
| .height(lineHeight * 3), |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning
| } | ||
|
|
||
| val columns = if (windowSize.width == WindowType.Compact) { | ||
| GridCells.Fixed(2) // phone |
Check warning
Code scanning / detekt
Reports multiple space usages Warning
| val columns = if (windowSize.width == WindowType.Compact) { | ||
| GridCells.Fixed(2) // phone | ||
| } else { | ||
| GridCells.Fixed(3) // tablet / larger |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning
| val columns = if (windowSize.width == WindowType.Compact) { | ||
| GridCells.Fixed(2) // phone | ||
| } else { | ||
| GridCells.Fixed(3) // tablet / larger |
Check warning
Code scanning / detekt
Reports multiple space usages Warning
2 participants
No description provided.