refactor: update SegmentActionBar to a Resources panel with improved …#408
Open
dhakar66 wants to merge 15 commits into
Open
refactor: update SegmentActionBar to a Resources panel with improved …#408dhakar66 wants to merge 15 commits into
dhakar66 wants to merge 15 commits into
Conversation
…layout and functionality - Renamed _BottomActionPanel to _ResourcesPanel and updated its structure. - Introduced copy and share buttons with dedicated widgets for better clarity. - Enhanced the layout to include a title and improved spacing for a more user-friendly interface. - Updated the action handling for commentary and version selection. - Added a back button to the reader bottom panel for improved navigation.
Contributor
Confidence Score: 4/5The bookmark and UI changes are safe, but the removal of the duplicate-recitation guard in the routine editor can silently write duplicate entries to the user's practice routine. The interactive _addRecitationToBlock path no longer checks whether the selected recitation is already present in that block before adding it and syncing to the API. Previously the guard produced a snackbar and returned early; now the same item can be added multiple times without any feedback. The series-enrollment code in the same file still explicitly enforces per-block deduplication, confirming this was not an intentional design change. lib/features/practice/presentation/screens/edit_routine_screen.dart — the _addRecitationToBlock method lost its duplicate-prevention check. Reviews (10): Last reviewed commit: "refactor: streamline recitation handling..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
- Added "resources" key to localization files for multiple languages (bo, en, hi, mn, ne, zh). - Updated pubspec.lock and Podfile.lock to reflect new package versions and checksums. - Modified segment action bar to use localized "resources" string.
…bottom_panel_shell.dart Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
- Introduced a new bookmark icon in AppAssets. - Added "Tools" and "Bookmark" translations in multiple languages. - Updated the UI to include a bookmark button in the resources panel.
…om/OpenPecha/Flutter-Pecha into feat/TextReaderDraggableNewVersion
- Introduced a new button in the reader app bar to open a "more" bottom sheet for additional options. - Implemented the `_openMoreBottomSheet` method to handle the display of the new bottom sheet. - Removed unused font size button references from the app bar for cleaner code. - not yet implemented the bookmark funcitonality and add to my practices logic.
- Introduced a new BookmarksScreen to manage user bookmarks with a tabbed interface. - Updated app routing to include a new route for bookmarks. - Modified PracticeExploreScreen to navigate to the bookmarks screen when the bookmarks button is tapped.
- Added BookmarkRemoteDatasource to handle API interactions for creating bookmarks. - Created BookmarkRepository to manage bookmark creation logic and error handling. - Developed BookmarkController to facilitate bookmark creation from the UI. - Integrated bookmark functionality into SegmentActionBar and ReaderMoreBottomSheet for user interaction. - Introduced CreateBookmarkParams for structured bookmark creation requests.
- Added initialRecitation parameter to EditRoutineScreen for better integration of recitation data. - Updated app routing to support navigation from recitation lists to the reader screen. - Modified PracticeChantsSection and MyRecitationsTab to utilize the new navigation context for recitations. - Enhanced ReaderMoreBottomSheet to conditionally show "Add to my practices" option based on recitation context. - Introduced new NavigationSource values for recitationList and routine to improve navigation context management.
…der components - Removed duplicate recitation checks from EditRoutineScreen to simplify the injection of initial recitation data. - Updated ReaderScreen to eliminate unnecessary routine data checks, enhancing performance and clarity. - Adjusted ReaderMoreBottomSheet to remove the isInPractices parameter, simplifying the UI logic for adding practices. - Improved navigation context handling for recitations in the reader flow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…layout and functionality