Refactor TTS service to remove unsupported language check#813
Conversation
tenkus47
commented
Jun 25, 2026
tenkus47
commented
- Removed the check for unsupported languages in the TTS audio generation function, allowing for non-Tibetan languages to be processed.
- Updated tests to validate the handling of non-Tibetan languages and ensure correct audio generation.
- Enhanced test coverage for TTS audio generation routes, confirming proper responses for various language inputs.
- Removed the check for unsupported languages in the TTS audio generation function, allowing for non-Tibetan languages to be processed. - Updated tests to validate the handling of non-Tibetan languages and ensure correct audio generation. - Enhanced test coverage for TTS audio generation routes, confirming proper responses for various language inputs.
Confidence Score: 4/5Safe to merge after renaming the duplicate test function — the production logic change is correct and well-scoped. The service change itself is clean. The only defect is in the test file: a newly added test reuses the name of an existing function, which causes Python to silently drop the first definition. The "TTS generation returned no audio data" runtime error path is no longer tested, meaning a regression there would go undetected. Fixing it requires a one-line rename. tests/plans/audio/test_tts_test_views.py — the duplicate function name at line 68 needs to be renamed. Reviews (1): Last reviewed commit: "Refactor TTS service to remove unsupport..." | Re-trigger Greptile |
|
2 participants
