Skip to content

Update minor fix#808

Closed
tenkus47 wants to merge 3 commits into
developfrom
update_minor_fix
Closed

Update minor fix#808
tenkus47 wants to merge 3 commits into
developfrom
update_minor_fix

Conversation

@tenkus47

Copy link
Copy Markdown
Member

No description provided.

tenkus47 added 2 commits June 25, 2026 11:19
…nality

- Changed the DATABASE_URL in the configuration to point to a new PostgreSQL instance.
- Introduced a new function `get_series_plan_schedule_by_series_ids` to retrieve lightweight plan fields and item counts for series scheduling.
- Updated the series service to utilize the new scheduling function, replacing the previous method.
- Added tests to ensure the correctness of the new scheduling functionality and its integration with existing services.
@tenkus47 tenkus47 requested a review from Tech-lo June 25, 2026 07:07
@greptile-apps

greptile-apps Bot commented Jun 25, 2026

Copy link
Copy Markdown

Confidence Score: 5/5

The PR is safe to merge — the changes are targeted, well-covered by new tests, and the functional corrections (end-date formula, language fallback) align with the explicit test assertions added alongside them.

The config deletion resolves a prior security concern. The group-language and series-schedule changes are each backed by multiple dedicated tests that verify both the happy path and meaningful edge cases (draft plans, missing start dates, language fallback chains). No regressions are introduced on the tested paths.

No files require special attention. The schedule calculation change in series_service.py is the most logic-dense area, but it is directly exercised by the new test_series_schedule_from_plans_* tests.

Reviews (2): Last reviewed commit: "Remove configuration file `config.py` fr..." | Re-trigger Greptile

Comment thread pecha_api/config.py Outdated
Comment thread pecha_api/plans/series/series_service.py
@sonarqubecloud

Copy link
Copy Markdown

…efault settings and environment variable management functions.
@tenkus47 tenkus47 closed this Jun 25, 2026
@tenkus47 tenkus47 deleted the update_minor_fix branch June 25, 2026 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants