Conversation
sk4zuzu
commented
Sep 8, 2026
sk4zuzu
commented
Collaborator
- Disable helper/fw by default
- Detect and support ufw and firewalld
- Do not attempt full management, open ports only on a best-effort basis
- Provide default rules for OpenNebula FEs/HVs
- Disable helper/fw by default - Detect and support ufw and firewalld - Do not attempt full management, open ports only on a best-effort basis - Provide default rules for OpenNebula FEs/HVs Signed-off-by: Michal Opala <sk4zuzu@gmail.com>
Signed-off-by: Michal Opala <sk4zuzu@gmail.com>
This was
linked to
issues
Sep 8, 2026
Collaborator
Author
|
@dann1 Hi, I'm thinking maybe "skip: t/f" would be better here than setting "groups.peers: null" to actually skip the rule. WDYT? 🤔 |
Collaborator
|
Hi @sk4zuzu I saw the PR open yesterday. I'll try to review it today/tomorrow. Just gave it a quick overview and it was looking very good. Can't really answer the question now though 😅 |
Collaborator
Author
|
@dann1 Relax 👍🤗 I'll add the "skip" change anyway I think (feels right), we can always revert it before merging. |
Signed-off-by: Michal Opala <sk4zuzu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.