Skip to content

chore(bundle): budget the Instant A825 driver - #1532

Open
its-benjamin wants to merge 1 commit into
OpenMouse-Project:mainfrom
its-benjamin:feat/instant-a825-budget
Open

its-benjamin wants to merge 1 commit into
OpenMouse-Project:mainfrom
its-benjamin:feat/instant-a825-budget

Conversation

@its-benjamin

@its-benjamin its-benjamin commented Nov 18, 2026 •

Copy link
Copy Markdown

Change

Raises the JS bundle total budget from 4,000,000 to 4,010,000 bytes and records
the reason and measurement in build/check-bundle-size.ts.

Why

OpenMouse-Project/mouse-protocol#310 adds the read-only Instant A825 driver
(Sades Kaze). Measured with the local protocol package:

Asset Measured Budget
JS total 4,000,437 4,000,000 (proposed 4,010,000)
main-*.js 1,463,361 1,600,000
CSS 177,456 178,000

The 10,000-byte increase covers the measured growth (about 8 kB) with about
1.5 kB of headroom. The main chunk and CSS stay under their separate caps.

Checks

  • npm run check with the local @openmouse/protocol build: 668 tests passed,
    bundle size passed.
  • No application code changes; only the budget note and value.

Matching protocol pull request: OpenMouse-Project/mouse-protocol#310.

Note

Raise JS bundle budget to 4,010,000 bytes for Instant A825 driver

Bumps the JavaScript bundle budget from 4,000,000 to 4,010,000 bytes in check-bundle-size.ts to make room for the Instant A825 read-only driver. Adds a measurement note for the new driver. The CSS budget is unchanged.

Macroscope summarized 4f392d2.

Summary by CodeRabbit

  • Chores
    • Updated the tracked JavaScript bundle-size allowance to account for the small increase associated with the Instant A825 read-only driver. This change reflects the measured bundle and main-chunk sizes; it updates release tracking rather than describing a change to user-facing behavior. No other user-visible changes are noted.

- Raises the JS total budget from 4,000,000 to 4,010,000 bytes with the measured size and reason.
- Matches OpenMouse-Project/mouse-protocol#310: the read-only A825 driver adds about 8 kB of JS.
@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The JavaScript bundle-size check now allows 4,010,000 bytes instead of 4,000,000 bytes. A comment records the Instant A825 read-only driver’s approximate JavaScript addition and measured bundle sizes.

Changes: JavaScript bundle budget

Layer / File(s) Summary
Document and update the JavaScript budget
build/check-bundle-size.ts
A comment records the Instant A825 read-only driver’s approximate 8 kB addition and measured bundle sizes. The JavaScript budget increases from 4,000,000 to 4,010,000 bytes.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Possibly related issues

Possibly related PRs

Suggested reviewers: snekxs, macroscopeapp

Merge Risk: Minimal · up to 4f392

This raises the JavaScript bundle size budget to allow for the new read-only A825 driver. It does not change runtime behavior and carries no meaningful merge risk.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "chore(bundle): budget the Instant A825 driver" matches the main change. The PR raises the JavaScript bundle budget in build/check-bundle-size.ts from 4,000,000 to 4,010,000 bytes to account…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "chore(bundle): budget the Instant A825 driver" matches the main change. The PR raises the JavaScript bundle budget in build/check-bundle-size.ts from 4,000,000 to 4,010,000 bytes to account for the read-only Instant A825 driver, and the title names both the change type and the driver. The title is concise and specific, and it does not list files or use vague terms.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between d4afe1e and 4f392d2.

Files selected for processing: 1

  • build/check-bundle-size.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

@github-actions github-actions Bot added type: maintenance PR title category: maintenance area: ci Automation and build configuration labels Nov 18, 2026
@its-benjamin
its-benjamin marked this pull request as ready for review November 18, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ci Automation and build configuration type: maintenance PR title category: maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant