Repository navigation
fix(native-hid): release builds never load the HID helper from the build machine's checkout path - #117
Merged
snekxs merged 1 commit intoNov 13, 2026
Conversation
…ild machine's checkout path When the bundled apply.mjs is missing, release binaries fell back to the build machine's checkout path (a CI runner's D:\a\... on Windows), which another account could create and fill. That dev fallback is now used only by debug builds and by binaries run from inside that checkout. The bundled helper paths are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
native-hid/src/apply.mjsisn't next to the executable, Bridge falls back to the source checkout it was built from (CARGO_MANIFEST_DIR, baked in at compile time). For a release binary that's the CI runner's path,D:\a\...on Windows. Any account on the user's machine can createD:\a\...and drop its ownapply.mjsthere, and Bridge would run it with Node.What changed:
cargo build --release, thentarget/release/...). Debug builds keep the fallback as before.Tested:
a_release_build_uses_the_checkout_only_from_inside_it: the test binary counts as inside its own folder, a made-up checkout does not, and debug builds always allow the fallback.cargo fmt --check,cargo test --locked, and clippy with-D warningsfor Linux and x86_64-pc-windows-gnu all pass.D:\a\...checkout to watch it get refused.🤖 Generated with Claude Code