Repository navigation
feat(panel): close the panel when you click elsewhere - #113
lmaoskript wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Thanks for this. Two things before it can merge: 1. Needs a rebase. #112 has landed on main ( 2. Manual testing on Windows and macOS. The blur-to-hide path isn't covered by tests and CI only compiles it on those platforms. Could you confirm in the running app:
Minor, no change needed: if the panel blurs for an unrelated reason, a tray click within 500 ms is swallowed. The |
The tray panel now hides to the tray when it loses focus, like a popup, on Windows, macOS and the Wayland layer-shell panel. A normal Linux window (no layer-shell) keeps its taskbar behaviour and stays open. Pressing the tray icon takes the panel's focus before the click arrives, so a click on the icon within half a second of that hide leaves the panel closed instead of toggling it straight back open.
|
Thanks for the review! Rebased onto main, so it's just the focus-loss commit now. I'm on Linux, so I can't test it on Windows or macOS, sorry. If someone with either of those could run through your checklist, that'd be great. |
35222b7 to
156379e
Compare
The tray panel now hides to the tray when you click anywhere outside it, like a popup.
This builds on #112 and includes its commit. Merge that one first; after it lands, this diff is just the last commit.
What changed:
On Wayland this only works if the panel got keyboard focus when it opened (the existing activation-token code, which also makes Escape work). If the compositor never gives it focus, clicking elsewhere leaves it open, as before.
Tested:
cargo fmt --check,cargo test --locked, and clippy with-D warningspass on Linux.🤖 Generated with Claude Code
Summary by CodeRabbit