Makefile.system: when Clang is used, check if gfortran is used#5801
Open
pkubaj wants to merge 1 commit intoOpenMathLib:developfrom
Open
Makefile.system: when Clang is used, check if gfortran is used#5801pkubaj wants to merge 1 commit intoOpenMathLib:developfrom
pkubaj wants to merge 1 commit intoOpenMathLib:developfrom
Conversation
At least on power, GCCVERSIONGT4 is checked for when gfortran is used, like at Makefile.power:59
Collaborator
|
I wonder if we could simply drop this check - it was somewhat useful back in the day when POWER9 was new and some distributions still defaulted to gcc4 ? (At least now it does no harm except generate a spurious message) |
Contributor
Author
|
A spurious message and it downgrades to -mcpu=power8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At least on power, GCCVERSIONGT4 is checked for when gfortran is used, like at Makefile.power:59