Remove Wing area from Simple Landing builder defaults#1215
Open
cmbenne3 wants to merge 11 commits into
Open
Conversation
…gy state landing system
jkirk5
requested changes
Jul 6, 2026
| ) | ||
|
|
||
| add_aviary_input(self, Aircraft.Wing.AREA, val=700) | ||
| add_aviary_input(self, Aircraft.Wing.AREA, val=1370) |
Contributor
Contributor
Author
There was a problem hiding this comment.
Resolved - val removed from add_aviary_input call. We use set_input_defaults() in the tests instead
…ng as they will be depricated in future
… without hardcoded density and unit conversions
…ASP nor FLOPS allows for input or override of this variable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue 980 and removes the set input default calls for the energy state landing group, which were unnecessary.
This simplifies the configurator and landing builder.
The landing component is updated to remove hardcoded density/unit conversion for calculation of Landing.INITIAL_VELOCITY. OpenMDAO now handles units and the dynamic density input is used.
Incorrect historical names removed from meta data for Landing.INITIAL_VELOCITY variable and replaced with the closest equivalent local and output variables from GASP and FLOPS. These mappings have no impact on functionality since neither ever appear in input files, but are included for completeness and to assist legacy code users with understanding the Aviary variable hierarchy.
Related Issues
Backwards incompatibilities
Any custom scripts using the Landing class builder will fail.
FLOPS made the assumption that altitude = sea level for calculation of Landing.INITAL_VELOCITY (VAPP). This has now been updated to correctly use Dynamic.Atmosphere.DENSITY so will now differ from FLOPS values where landing altitude is greater than sea level.
VAPPR will no longer be converted from FLOPS input files with the fortran_to_aviary() function (however Aviary wasn't correctly interpreting this conversion anyway)
AI Usage
AI was used for assistance with changes to compute_partials() for the landing component.