Skip to content

Remove Wing area from Simple Landing builder defaults#1215

Open
cmbenne3 wants to merge 11 commits into
OpenMDAO:mainfrom
cmbenne3:issue980
Open

Remove Wing area from Simple Landing builder defaults#1215
cmbenne3 wants to merge 11 commits into
OpenMDAO:mainfrom
cmbenne3:issue980

Conversation

@cmbenne3

@cmbenne3 cmbenne3 commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR addresses issue 980 and removes the set input default calls for the energy state landing group, which were unnecessary.
This simplifies the configurator and landing builder.

The landing component is updated to remove hardcoded density/unit conversion for calculation of Landing.INITIAL_VELOCITY. OpenMDAO now handles units and the dynamic density input is used.

Incorrect historical names removed from meta data for Landing.INITIAL_VELOCITY variable and replaced with the closest equivalent local and output variables from GASP and FLOPS. These mappings have no impact on functionality since neither ever appear in input files, but are included for completeness and to assist legacy code users with understanding the Aviary variable hierarchy.

Related Issues

Backwards incompatibilities

Any custom scripts using the Landing class builder will fail.

FLOPS made the assumption that altitude = sea level for calculation of Landing.INITAL_VELOCITY (VAPP). This has now been updated to correctly use Dynamic.Atmosphere.DENSITY so will now differ from FLOPS values where landing altitude is greater than sea level.

VAPPR will no longer be converted from FLOPS input files with the fortran_to_aviary() function (however Aviary wasn't correctly interpreting this conversion anyway)

AI Usage

AI was used for assistance with changes to compute_partials() for the landing component.

@cmbenne3 cmbenne3 changed the title remove Wing area from Landing Group defaults Remove Wing area from Landing Group defaults Jul 2, 2026
@cmbenne3 cmbenne3 changed the title Remove Wing area from Landing Group defaults Remove Wing area from Simple Landing builder defaults Jul 2, 2026
)

add_aviary_input(self, Aircraft.Wing.AREA, val=700)
add_aviary_input(self, Aircraft.Wing.AREA, val=1370)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use of val here doesn't actually do anything and will be removed soon (see #1196, #1206). You'll need to update the test to directly set that value to get matching results instead

@cmbenne3 cmbenne3 Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved - val removed from add_aviary_input call. We use set_input_defaults() in the tests instead

@cmbenne3 cmbenne3 requested a review from jkirk5 July 7, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants