Protobuf AddDescriptors should be removed for all versions of protobu… - #1638
Merged
Merged
Conversation
…f since 3.2 instead of 3.7. See OpenLightingProject#1192 and OpenLightingProject#1336
peternewman
approved these changes
May 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…f since 3.2 instead of 3.7. See #1192 and #1336
#1630 fixed building against protobuf > 3.7. However, some things fixed were also required for versions from 3.2 on already. This PR changes the version numbers of protobuf in the conditionals so it also works with protobuf 3.2 to 3.6.
Tested with protobuf 3.11.4 and all tests PASSED.