Fixed misleading expansion variable log message in ci.common - #532
Merged
venmanyarun merged 4 commits intoAug 24, 2026
Merged
Conversation
venmanyarun
approved these changes
Aug 17, 2026
cherylking
requested changes
Aug 19, 2026
…alue instead of the full expression buffer by moving the log call inside the while loop.
cherylking
requested changes
Aug 20, 2026
Contributor
Author
|
Below are the logs captured in different scenarios Scenario 1: single variable Scenario 2: two variables combined Scenario 3: recursive NOTE: ${ROOT}/semeru appears twice because it's resolved once for JDK and again when resolving JAVA_HOME_DERIVED through JDK |
cherylking
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes OpenLiberty/ci.maven#2076
Reference: OpenLiberty/ci.maven#2076 (comment)
Moved the log call to after the full string is assembled, so the complete resolved path is shown, and updates the message format to clearly state which variable was expanded, the original expression it appeared in, and the fully resolved result. The corresponding IT assertions in ci.maven and ci.gradle are updated to match the new message format.