test: Add 25 WRAP_ACTIONS conformance fixtures for coverage gaps - #157
Open
leongdl wants to merge 1 commit into
Open
test: Add 25 WRAP_ACTIONS conformance fixtures for coverage gaps#157leongdl wants to merge 1 commit into
leongdl wants to merge 1 commit into
Conversation
25 fixtures closing gaps from the RFC 0008 coverage audit: absent-by-design host vars, macro-by-emitter matrix, stderr forwarding, variable scope negatives (incl. in-expression and in-let variants), the four missing all-or-nothing hook subsets, nesting depth 2, variables-only inner env, failure-path breadth, and the FEATURE_BUNDLE_1-gated fmtstring positive twin. Suite: 72 -> 97 passing. Spec-correct fixtures that FAIL against current implementations are split to the companion branch conformance-wrap-actions-expected-failures. Signed-off-by: David Leong <116610336+leongdl@users.noreply.github.com>
Contributor
Author
|
CI note: two fixtures fail on CI but passed local validation against openjd-rs main (wrap-failed-exit-hook-own-onexit-still-runs, wrap-grand-child-fails-under-enter-hook) — likely a released-vs-main CLI version difference or Linux/macOS platform difference; investigating before marking ready. Mainline CI is also currently red for every PR due to two pre-existing broken fixtures unrelated to this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
25 WRAP_ACTIONS fixtures closing gaps identified by a systematic coverage audit of RFC 0008 against the existing suite. All 25 validated individually through the conformance runner against openjd-rs; full suite goes 72 → 97 passing, 0 failing.
Areas covered
HOME,PATH,OPENJD_*) must NOT appear inWrappedAction.Environment— pinned withexpected.forbidden. Previously a runtime forwardingos.environwholesale passed every fixture.openjd_envemitted by the wrap script itself; by a task grand-child and visible in the next task'sWrappedAction.Environment; by a grand-child underonWrapEnvExit;openjd_progress/openjd_statusforwarding; stderr forwarding; and the negative control that a wrap script discarding grand-child stdout loses the macro (pins "MUST NOT scan the grand-child directly").WrappedEnv.NameinonWrapTaskRunrejected;WrappedStep.Namein both env hooks rejected; out-of-scopeWrappedAction.*buried inside an EXPR function call and inside aletbinding — a validator that only walks format strings passes the pre-existing negative and misses these.WrappedEnv.Namecorrect per invocation.variables:-only inner environment (noscriptat all) runs no wrap hooks — named in the RFC and schema constraint 5, previously untested.onWrapEnvExit→ wrapping env's ownonExitstill runs; grand-child failure under the enter hook propagates; unwrapped-parity control.timeoutandcancelation.modeon wrap hooks accepted when the extension IS listed (only the reject side existed).Verification
Every fixture executed via
run_openjd_cli_tests.pyagainst openjd-rs. Negatives verified to reject for the exact RFC 0008 rule under test (not an incidental reason). Cross-platform viapython -c; no newrunOngates.Companion PR
Spec-correct fixtures that FAIL against current implementations are in a separate expected-failures PR (branch
conformance-wrap-actions-expected-failures) so this one merges green.