-
Notifications
You must be signed in to change notification settings - Fork 20
chore(release): 0.7.6 #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This release note states unconditionally that "A step's environments are entered with its step-level EXPR let bindings (RFC 0007)", but at the dependency floor declared in
pyproject.tomlthat isn't true.src/openjd/cli/_run/_local_session/_session_manager.py:443reads the bindings defensively:but
pyproject.tomlpinsopenjd-model >= 0.9,< 0.12. On any resolvedopenjd-modelolder than the release that addedStep.let,getattrreturnsNone, soextra_let_bindingsis never forwarded and step-levelletsilently no-ops — environmentvariablesand actions that reference those bindings will fail to resolve (or resolve to nothing) with no error explaining why. A user installingopenjd-cli==0.7.6with an older-but-permittedopenjd-modelgets a release that advertises the feature and doesn't have it.Note the sibling
openjd-sessionsfloor was raised to>= 0.10.11in this same release precisely to remove an equivalent version-skew guard; theopenjd-modelfloor appears to have been left behind. Suggest either raising theopenjd-modellower bound to the first version withStep.let(and dropping thegetattrfor a plainstep.let), or qualifying this changelog bullet so the requirement is visible to users.