Skip to content

Use the dedicated ICON_CONNECTOR to represent a connector in the dashboard#292

Merged
tonygermano merged 1 commit intoOpenIntegrationEngine:mainfrom
sbraconnier:feature/icon-connector
May 7, 2026
Merged

Use the dedicated ICON_CONNECTOR to represent a connector in the dashboard#292
tonygermano merged 1 commit intoOpenIntegrationEngine:mainfrom
sbraconnier:feature/icon-connector

Conversation

@sbraconnier
Copy link
Copy Markdown
Contributor

Fix #291

In the TagTreeCellRenderer class, this block (line 108):

if (status.getStatusType() == StatusType.CHANNEL) {
    icon = UIConstants.ICON_CHANNEL;
    channel = true;
}

has been changed to this:

if (status.getStatusType() == StatusType.CHANNEL) {
    icon = UIConstants.ICON_CHANNEL;
    channel = true;
} else if (status.getStatusType() == StatusType.SOURCE_CONNECTOR || status.getStatusType() == StatusType.DESTINATION_CONNECTOR) {
    icon = UIConstants.ICON_CONNECTOR;
}

The result is this:

Icon_Connector_Screenshot 2026-04-08 004221

Instead of this:

Icon_Channel_Screenshot 2026-04-08 004326

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 8, 2026

Test Results

  111 files  ±0    214 suites  ±0   6m 54s ⏱️ + 1m 7s
  654 tests ±0    654 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 308 runs  ±0  1 308 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f844f6d. ± Comparison against base commit cd1110e.

♻️ This comment has been updated with latest results.

@sbraconnier sbraconnier force-pushed the feature/icon-connector branch from a9e687c to 9bb72e6 Compare April 8, 2026 12:41
@sbraconnier sbraconnier marked this pull request as ready for review April 8, 2026 12:50
@NicoPiel NicoPiel requested review from a team, NicoPiel, gibson9583, jonbartels, kayyagari, mgaffigan, ssrowe and tonygermano and removed request for a team April 10, 2026 07:32
@mgaffigan mgaffigan force-pushed the feature/icon-connector branch from 9bb72e6 to 0c048b9 Compare April 11, 2026 23:21
@tonygermano
Copy link
Copy Markdown
Member

Regression is from commit 3004984 first appearing in mirth 3.5.0.

…board (OpenIntegrationEngine#291)

This fixes a regression bug introduced in mirth 3.5.0 with commit
3004984

Issue: OpenIntegrationEngine#291
Signed-off-by: sbraconnier <simonbraconnier@gmail.com>
@tonygermano tonygermano force-pushed the feature/icon-connector branch from 0c048b9 to f844f6d Compare May 7, 2026 22:46
@tonygermano tonygermano merged commit f844f6d into OpenIntegrationEngine:main May 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use the dedicated ICON_CONNECTOR in the dashboard to represent a connector.

5 participants